Conversation
thboop
force-pushed
the
thboop/AddFileCommands
branch
from
fe0ee5a to
8d1441e
Compare
ericsciple
reviewed
Sep 11, 2020
ericsciple
approved these changes
Sep 11, 2020
Contributor
ericsciple
left a comment
ericsciple
left a comment
There was a problem hiding this comment.
looks good, discussed offline
ericsciple
reviewed
Sep 22, 2020
| issueCommand('set-env', {name}, convertedVal) | ||
|
|
||
| const filePath = process.env['GITHUB_ENV'] || '' | ||
| if (filePath && filePath.length > 0) { |
Contributor
There was a problem hiding this comment.
nit: truthy check is sufficient (ensures length > 0)
ericsciple
reviewed
Sep 22, 2020
ericsciple
reviewed
Sep 22, 2020
ericsciple
reviewed
Sep 22, 2020
tjamet
added a commit
to actions-go/toolkit
that referenced
this pull request
Nov 2, 2020
Backport implementation from actions/toolkit#571
tjamet
added a commit
to actions-go/toolkit
that referenced
this pull request
Nov 2, 2020
* Add SetFailedf and IsDebug helpers SetFailedf prevents from having to use Sprintf in caller methods * Backport new ExportVariable and SetPath Backport implementation from actions/toolkit#571
akkim31
approved these changes
Dec 23, 2020
| export function toCommandValue(input: any): string { | ||
| if (input === null || input === undefined) { | ||
| return '' | ||
| } else if (typeof input === 'string' || input instanceof String) { |
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.