Update location of typescript definitions#743
Merged
thboop merged 1 commit intoactions:mainfrom May 20, 2021
prince-chrismc:patch-1
Merged
Update location of typescript definitions#743thboop merged 1 commit intoactions:mainfrom prince-chrismc:patch-1
thboop merged 1 commit intoactions:mainfrom
prince-chrismc:patch-1
Conversation
This was referenced Mar 22, 2021
Closed
Contributor
Author
|
Hi @thboop 👋 I see you've recently merged some PRs. If you get the chance to look at this, it would be greatly appreciated! |
thboop
approved these changes
May 20, 2021
Collaborator
thboop
left a comment
thboop
left a comment
There was a problem hiding this comment.
LGTM thanks for the contribution!
Collaborator
|
@prince-chrismc LGTM thanks for the contribution and ping! 🚀 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe they may have changed at some point, it seems it was apart of the
v8.0.0release... related PR octokit/webhooks.js#444https://github.com/octokit/webhooks.js#typescript now points to
@octokit/webhooks-definitionsfollowing that readme I was able to get my code to work.closes #669
resolves #722
resolves #746