Skip to content

Cache: Delete temporary archive after upload#792

Merged
konradpabjan merged 1 commit intoactions:mainfrom
rcowsill:post-save-cleanup
Jun 28, 2021
Merged

Cache: Delete temporary archive after upload#792
konradpabjan merged 1 commit intoactions:mainfrom
rcowsill:post-save-cleanup

Conversation

@rcowsill
Copy link
Copy Markdown
Contributor

@rcowsill rcowsill commented May 5, 2021

This is to avoid filling the SSD while saving multiple large caches

Fixes #791

@rcowsill rcowsill marked this pull request as ready for review May 6, 2021 13:14
@rcowsill rcowsill requested a review from a team May 6, 2021 13:14
@rcowsill rcowsill changed the title Delete temporary archive after cache upload Cache: Delete temporary archive after upload May 6, 2021
This is to avoid filling the SSD while saving multiple large caches
@rcowsill rcowsill force-pushed the post-save-cleanup branch from 8a5f0b4 to f641f0f Compare May 24, 2021 13:56
@thboop thboop added the cache label May 27, 2021
Copy link
Copy Markdown
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the investigation and the PR!

@rcowsill
Copy link
Copy Markdown
Contributor Author

Do I need to do anything to address the toolkit-audit failure? I haven't changed the dependencies so I expect it to pass after the merge.

@thboop
Copy link
Copy Markdown
Collaborator

thboop commented Jun 28, 2021

Do I need to do anything to address the toolkit-audit failure? I haven't changed the dependencies so I expect it to pass after the merge.

No, thanks for bringing it up but we will take care of it! Feel free to ignore it on this PR.

@konradpabjan konradpabjan merged commit 4564768 into actions:main Jun 28, 2021
@rcowsill rcowsill deleted the post-save-cleanup branch June 30, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up temporary archive file at the end of saveCache

3 participants