Fixes Issue#5 and use adafruit_register

[barbudor]

Fixes Issue#5 and use adafruit_register

• Change internals to use adafruit_register for register and bit-field read/write
• Updated table of constants, including fix BusADCResolution values (Issue#5), add new values
• Add new properties to access registers (advanced API)
• Update ina219_simpletest to show some usage of the new properties

[siddacious]

hey @barbudor it looks like pylint found a few things to complain about; take a look and let me know if you have questions on how to resolve them:

https://travis-ci.com/adafruit/Adafruit_CircuitPython_INA219/builds/104711311

[barbudor]

@siddacious Many thanks for your help to make my 1st PR

[barbudor]

Last comment : tested on CPX with CP 4.0.0.beta5

[ladyada]

as its one bit, this could just be True or False instead of a custom class?

[deshipu]

I think it doesn't make any sense to use const() inside classes — it only works with global variables.

[barbudor]

Hi @ladyada, indeed this one is useless and should be removed. I will do it as soon as no more review is expected.

Hi @deshipu, I'm dupplicating what I've seen in IN260 : https://github.com/adafruit/Adafruit_CircuitPython_INA260/blob/master/adafruit_ina260.py
Using classes for constant allows to use meaning full names such as Mode.CONTINUOUS
I believe this is the same as DigitalInOut.Direction.OUTPUT
My understanding is that a const()will use less memory than a variable.

[barbudor]

Does it makes sense to keep this one too ?
class BusVoltageRange:
"""Constants for bus_voltage_range"""
RANGE_16V = const(0x00) # set bus voltage range to 16V
RANGE_32V = const(0x01) # set bus voltage range to 32V (default)

May be renaming bus_voltage_range as bus_voltage_range_32V and use False/True ?

[deshipu]

@barbudor

const() works by replacing every occurrence of a variable with the number itself before compiling the code. It only works with globals, because otherwise it would need to know the runtime context of the variable to be able to tell if it's really this variable or some other local variable that just happens to be named the same. It makes the code slightly faster by avoiding variable lookup.

Since the global variable still needs to be created, so that it can be accessed by any other modules that import this module, it doesn't use less memory. For it to use less memory, you would need to: 1. use global variables, as already mentioned, 2. name them with an underscore as the first character, so that they can't be used by external modules. Then, and only then, it makes sense to use const(). Otherwise I would recommend removing it to avoid confusion.

[deshipu]

More details: micropython/micropython#573

[barbudor]

Hello
Sorry to bother
I'm just wondering if you are expecting anything from me or are just too busy with CPY 4.0?
Thanks
Best regards

[barbudor]

Thanks @tannewt

[ilario]

The reset class that was removed in this pull request is still mentioned here:

Adafruit_CircuitPython_INA219/adafruit_ina219.py

Line 141 in 1cce6de

# reset WO : Write Reset.RESET to reset the chip (must recalibrate)

to be used in conjunction with the reset thing here:

Adafruit_CircuitPython_INA219/adafruit_ina219.py

Line 167 in 1cce6de

reset = RWBits(1, _REG_CONFIG, 15, 2, False)

Currently, it is unclear how to use the reset function.