Conversation
|
Note: this should bump to 2.0.0 when released because the class name change from |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One question about what the new constructor args should be.
You could also make a function that looks like the old class SPA06_003_I2C() and does the I2CDevice wrapping. It should probably have a deprecation warning though too.
|
The latest commit has |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
A couple minor things. Definitely getting close. Thanks!
adafruit_spa06_003.py
Outdated
| time.sleep(0.01) | ||
|
|
||
|
|
||
| class SPA06_003_I2C(SPA06_003): |
There was a problem hiding this comment.
Do we still need a class? Or can this be a function?
Also, please use the warnings module. I believe most CP builds will have it.
There was a problem hiding this comment.
I changed this to a function and use warnings module in the latest commit.
Thank you
Updating https://github.com/adafruit/Adafruit_CircuitPython_SPA06_003 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SPA06_003#1 from FoamyGuy/spi_support Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_STHS34PF80
2 participants
This relies on the changes from: adafruit/Adafruit_CircuitPython_Register#59 So that should be merged before this is.
Adds SPI support by using new functionality pending addition to adafruit_register
This should be a major version bump if merged because the class name changed from the bus specific SPA06_003_I2C to the now generic SPA06_003.
Tested successfully with both SPI and I2C on
Adafruit CircuitPython 10.0.0-beta.3 on 2025-08-29; Adafruit Feather RP2040 with rp2040