fix reboot loop - set REGOUT0 only when value is erased to default#344
Merged
hathach merged 1 commit intoadafruit:masterfrom Feb 7, 2025
Merged
fix reboot loop - set REGOUT0 only when value is erased to default#344hathach merged 1 commit intoadafruit:masterfrom
hathach merged 1 commit intoadafruit:masterfrom
Conversation
this fixes reboot loop when REGOUT0 is explicitly set to different value that cannot be rewritten by clearing bits in flash
Contributor
Author
|
Actually when thinking about it, it would now still cause loop if someone #defines UICR_REGOUT0_VALUE to be UICR_REGOUT0_VOUT_DEFAULT. This makes little sense and other code I see don't handle such misconfiguration too, but to be 100% correct we could change the |
15 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes reboot loop when REGOUT0 is explicitly set to different value (like 3.0V).
The main rationale for setting REGOUT0 UICR value at boot time is to correct the 1.8V default which is there when UICR is mass erased. However when user sets different value explicitly, current code causes never-ending reboot loop with board default of 3.3V because you can't set flash bits back from 0 to 1.
This code fragment is typical to change the value only if it is the default (all FFs), see other places
https://github.com/search?q=UICR_REGOUT0_VOUT_DEFAULT&type=code