feat: add support for SoftDevice S340#359
Conversation
hathach
left a comment
There was a problem hiding this comment.
thank you for your PR. I have update the makefile/cmake a bit to make it easier to manage. And move the s340 note to its own readme.md.
Also the ci _s340 filter is also reverted, since I am not sure if it is a good idea to include s340 boards to this repo whereas those boards are not actually buildable.
|
Hi @JuergenLeber! I’m a complete beginner at this, so please let me know if this isn't the right place to ask questions. Disclaimer: I’m very new to working with these boards and tools. I am attempting to build a custom treadmill sensor that uses ANT+ to broadcast data to my Garmin Fenix 8. I successfully updated my Adafruit nRF52840 Feather Express to the S340 bootloader (v0.10.0-dirty). Here is my NFO_UF2.TXT: The board still mounts correctly on my computer when double reset. However, after performing this update, I can't get anything to work. The Arduino IDE doesn't seem to recognize the changes, and I can't even upload a basic 'Blink' sketch anymore. Is there a specific board definition or a manual step I’m missing to make the Arduino IDE compatible with the S340 SoftDevice?" |
|
@eddyCG42 In a nutshell: The Arduino IDE doesn't know the S340 and as it is bigger it tries to link the code to the wrong addresses. You need to modify the linker scripts and boards.txt file. |
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
This PR adds the support for the SoftDevice S340 (with additional support for ANT/ANT+). The build for boards with S340 will only work locally after copying the closed source files in and the build is excluded for the build workflow on GitHub. Everything to do for S340 is documented in the README.md. Additionally an issue with disabling the SoftDevice has been fixed.