Skip to content

Update buildsystem#372

Merged
hathach merged 4 commits intomasterfrom
update-buildsystem
Dec 19, 2025
Merged

Update buildsystem#372
hathach merged 4 commits intomasterfrom
update-buildsystem

Conversation

@hathach
Copy link
Member

@hathach hathach commented Dec 19, 2025

  • update cmake build
  • add board.cmake
  • remove git submodules from uf2 version

Copilot AI review requested due to automatic review settings December 19, 2025 15:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CMake build system to improve the build infrastructure. The changes remove git submodule version tracking from the UF2 version string, add board-specific CMake configuration files for all supported boards, and clean up the build system by removing SEGGER-specific files and simplifying the toolchain configuration.

  • Simplifies version string by removing git submodule information
  • Adds board.cmake files for all boards to support CMake builds
  • Removes unused SEGGER Embedded Studio files
  • Modernizes CMake toolchain configuration and linker scripts

Reviewed changes

Copilot reviewed 67 out of 68 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/screen.c Updates comment and references from UF2_VERSION_BASE to UF2_VERSION
src/main.c Code cleanup: removes unused includes, adds braces for single-line if statements, reformats comments, fixes const qualifier position in assert_nrf_callback
src/boards/*/board.cmake Adds CMake board configuration files for all supported boards specifying MCU variant
segger/* Removes SEGGER Embedded Studio project files and RTT implementation (kept in lib/)
linker/*.ld Comments out GROUP statements and removes excess whitespace
cmake/toolchain/arm_gcc.cmake Simplifies toolchain setup, removes try_compile workarounds, inlines flag initialization
cmake/cpu/cortex-m4.cmake Simplifies to focus on GCC toolchain only
cmake/toolchain/set_flags.cmake Removed (functionality moved inline)
CMakeLists.txt Restructures build order, removes git submodule version tracking, simplifies debug configuration, adds new flash targets
Makefile Removes git submodule version tracking from UF2_VERSION
README.md Removes dollar signs from shell command examples for consistency
.clang-format Adds clang-format configuration for code formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hathach hathach merged commit 0147d71 into master Dec 19, 2025
108 checks passed
@hathach hathach deleted the update-buildsystem branch December 19, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants