Merged
Conversation
Member
hathach
commented
Dec 19, 2025
- update cmake build
- add board.cmake
- remove git submodules from uf2 version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CMake build system to improve the build infrastructure. The changes remove git submodule version tracking from the UF2 version string, add board-specific CMake configuration files for all supported boards, and clean up the build system by removing SEGGER-specific files and simplifying the toolchain configuration.
- Simplifies version string by removing git submodule information
- Adds board.cmake files for all boards to support CMake builds
- Removes unused SEGGER Embedded Studio files
- Modernizes CMake toolchain configuration and linker scripts
Reviewed changes
Copilot reviewed 67 out of 68 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/screen.c | Updates comment and references from UF2_VERSION_BASE to UF2_VERSION |
| src/main.c | Code cleanup: removes unused includes, adds braces for single-line if statements, reformats comments, fixes const qualifier position in assert_nrf_callback |
| src/boards/*/board.cmake | Adds CMake board configuration files for all supported boards specifying MCU variant |
| segger/* | Removes SEGGER Embedded Studio project files and RTT implementation (kept in lib/) |
| linker/*.ld | Comments out GROUP statements and removes excess whitespace |
| cmake/toolchain/arm_gcc.cmake | Simplifies toolchain setup, removes try_compile workarounds, inlines flag initialization |
| cmake/cpu/cortex-m4.cmake | Simplifies to focus on GCC toolchain only |
| cmake/toolchain/set_flags.cmake | Removed (functionality moved inline) |
| CMakeLists.txt | Restructures build order, removes git submodule version tracking, simplifies debug configuration, adds new flash targets |
| Makefile | Removes git submodule version tracking from UF2_VERSION |
| README.md | Removes dollar signs from shell command examples for consistency |
| .clang-format | Adds clang-format configuration for code formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.