Conversation
# Conflicts: # src/boards/boards.c # src/main.c
hathach
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Makes DFU/OTA button handling optional so the bootloader can build/run on boards without dedicated DFU/FRESET buttons.
Changes:
- Guard DFU/OTA button reads in
main.cbehind#if defined(...)checks. - Relax board requirements by no longer requiring 2 buttons at compile-time.
- Conditionally compile/declare button helpers only when relevant button macros exist.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/main.c | Avoids referencing undefined button macros; minor whitespace cleanups. |
| src/boards/boards.h | Stops enforcing “2 buttons required” and conditionally exposes button API. |
| src/boards/boards.c | Conditionally compiles button helpers and only initializes buttons when defined. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supercede #292 since we cannot push to update the other PR