added openstack metadata integration#65
Merged
adammck merged 4 commits intoadammck:masterfrom Jun 9, 2017
gitirabassi:openstack
Merged
added openstack metadata integration#65adammck merged 4 commits intoadammck:masterfrom gitirabassi:openstack
adammck merged 4 commits intoadammck:masterfrom
gitirabassi:openstack
Conversation
adammck
requested changes
Jun 9, 2017
Owner
adammck
left a comment
adammck
left a comment
There was a problem hiding this comment.
Looks good, just a few minor nits.
parser_test.go
Outdated
| "access_ip_v6": "", | ||
| "metadata.status":"superServer", | ||
| "metadata.#":"very bad", | ||
| "metadata_toes":"faada2142412jhb1j2" |
parser_test.go
Outdated
| "staging": ["192.168.0.3"], | ||
| "status_superserver": ["10.120.0.226"], | ||
| "database": ["10.0.0.8"] | ||
|
|
| g := k | ||
| groups = append(groups, g) | ||
| // Key-value | ||
| // Key-value |
Owner
There was a problem hiding this comment.
Is this a gofmt change? I know it's not part of this PR, but since we're touching it, please move it inside the else branch or remove it.
Contributor
Author
There was a problem hiding this comment.
yep, I checked it and it's gofmt
adammck
approved these changes
Jun 9, 2017
Owner
|
Thanks very much for the quick turnaround on this review! |
Contributor
Author
|
Sure no problem, Thank you for the great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello, I've added integration for openstack way of calling tags