test(server): lock in seller-response preference for MediaBuyStore (#1430)#1433
Merged
bokelley merged 2 commits intoMay 3, 2026
Merged
Conversation
…aBuyStore (#1430) Adds a unit test to mediaBuyStore.persistFromCreate that exercises the spec contract surfaced in PR #1424 protocol-expert review: when both request and response carry packages[i].targeting_overlay, the persisted echo reflects the seller's response (not the buyer's request copy). The behavior shipped in #1424 already prefers response over request, but no test pinned it — adding one prevents regression. Closes #1430. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1430. PR #1424 already preferred
response.targeting_overlayoverrequest.targeting_overlayinmediaBuyStore.persistFromCreate(per protocol-expert review feedback addressed in the rolled-up fixup commit), but no test pinned the behavior. This PR adds one.The new test simulates a normalizing seller — buyer sends
agent_url: 'https://buyer.example/lists', seller canonicalizes tohttps://lists.canonical.examplebefore persisting, response carries the canonicalized form. The store must echo the seller's normalized version, not the buyer's original.Test plan
npx vitest run src/lib/server/media-buy-store.test.ts— 10/10 pass🤖 Generated with Claude Code