docs(migration): warn that customTools["update_rights"] must be removed when upgrading to 6.7.0#1449
Conversation
… upgrading to 6.7.0 Without this note, brand-rights adopters who still have a `customTools.update_rights` registration see a lazy runtime error on the first request that looks like MCP discovery failure — not a startup error. Identified via adcp-client#1438 root-cause analysis. https://claude.ai/code/session_01V1MgRaahiwFFgpMc66eD2k
…pdate_rights note Fix two pre-PR review blockers: quote full error message including the remediation hint, and remove the redundant grep recipe from the body paragraph (now cross-referenced to the self-grade checklist). https://claude.ai/code/session_01V1MgRaahiwFFgpMc66eD2k
|
Superseded — recipe #16 on main ( |
|
Understood — acknowledged. Recipe #16 on main is the canonical home; the pointer approach is cleaner than inlining the same content here. Nothing further needed from this PR. Generated by Claude Code |
|
Acknowledged — closing the loop here. PR superseded by Recipe #16 on Generated by Claude Code Generated by Claude Code |
Refs #1438
docs/migration-6.6-to-6.7.mdmentioned theupdate_rightspromotion to a framework-registered first-class tool but didn't call out that adopters with a pre-existingcustomTools["update_rights"]registration must remove it. Without the note, a duplicate registration causescreateAdcpServer()to throw at construction time — and for server setups that build tenants lazily (e.g., registry patterns), that error surfaces on the first inbound request as an MCP discovery failure rather than a startup error, making the root cause hard to diagnose. The issue was surfaced by root-cause analysis of #1438.Changes:
**Breaking for customTools registrations:**note to theupdate_rightsfeature bullet in "What else changed," quoting the full error message and explaining the lazy-init discovery-failure symptomgrepaudit recipe so upgrading adopters have an actionable pre-flight checkNo changeset needed (docs-only change, per CLAUDE.md).
What tested:
npm run format:check— cleannpm run ci:docs-check— blocked by missingtsxin environment (pre-existing; same gap noted in PR fix(mcp): restore SSE fallback for loopback/private-address MCP servers #1442 body); docs content verified by manual readPre-PR review:
Session: https://claude.ai/code/session_01V1MgRaahiwFFgpMc66eD2k
Generated by Claude Code