chore: release package#1925
Merged
Merged
Conversation
69ca871 to
20685bf
Compare
20685bf to
0056891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@adcp/sdk@7.11.0
Minor Changes
e324942: Add
getSignalIdandgetSignalIssuerread helpers forSignalIDSignalIDis a discriminated union (source: 'catalog' | 'agent'). Callers that need just the segment identifier or the issuer domain/URL previously had to narrow the union manually or risk reaching for non-existent fields likesid.catalog_id.Two new exports from
@adcp/sdk:getSignalId(sid)— returnssid.id(the canonical segment identifier, present on both variants)getSignalIssuer(sid)— returnssid.data_provider_domain(catalog) orsid.agent_url(agent), with an exhaustiveness guard for future union variantsComplements the existing
signalId.catalog()/signalId.agent()write-path factories.Patch Changes
9ad3c36: fix(testing): read
media_buy_statusbefore legacystatuswhen storyboard invariants extract media-buy lifecycle observations.69bf3c7: refactor(v2): centralize AAO canonical agent URL into a shared constant
Extract
'https://creative.adcontextprotocol.org/'fromsynthesizeFormatIdFromGlob(registry.ts) intoAAO_CANONICAL_AGENT_URLin a newsrc/lib/v2/projection/constants.ts.No behavior change — the synthesized
agent_urlvalue is byte-identical.The JSDoc on the constant documents the distinction from
DEFAULT_MIRROR_HOSTS(an allowlist of hostnames for$refsandboxing,not an
agent_urlbase). Also clarifies the JSDoc onsynthesizeFormatIdFromGlobto note theagent_urlis non-normative(registry synthesis is implementation-defined per spec).
db06bd4: fix(codegen): extend TS7056 post-processor to emit typed
z.ZodType<T, T>annotationsThe Zod-from-TS post-processor in
scripts/generate-zod-from-ts.tsannotates schemas that hit TypeScript's.d.tsserialization limit (TS7056) withz.ZodTypeso the compiler stops trying to serialize the inferred shape. The previous annotation used the barez.ZodTypeform, which makesz.input<typeof X>resolve tounknown— breakingAdcpToolMap[K]['params']narrowing for any annotated request schema.Changes:
TS7056_SCHEMASentries now carry an optionaltsTypefield. When present, the annotation uses the 2-type-param Zod v4 formz.ZodType<T, T>with& Record<string, unknown>widening to reflect runtime.passthrough()semantics. Callers'z.input<...>reads resolve to the typed shape; downstream destructures keep their field types.import type { ... } from './tools.generated'for the typed annotations.PreviewCreativeRequestSchema,UpdateMediaBuyRequestSchema,UpdateMediaBuyResponseSchema,BuildCreativeResponseSchema,SyncEventSourcesResponseSchema) — they hit TS7056 on 3.1.0-beta.2 and the annotation is harmless on the current 3.0.12 pin.withOptionalAccount(UpdateMediaBuyRequestSchema)call site so the framework helper'sz.ZodObject<...>constraint is satisfied after the annotation widening. Runtime shape unchanged.Why pre-emptive: the 8.0-beta cut (feat!: cut 8.0-beta line — flip ADCP_VERSION to 3.1.0-beta.2 (foundation) #1902) needs this codegen behavior to compile its
dist/. Landing the codegen-tooling fix onmaindecouples it from the 8.0-beta foundation stack and gives any future 3.0.x patch that introduces compound-schema complexity the same treatment for free.