chore: release package#2249
Merged
bokelley merged 1 commit intoJun 17, 2026
Merged
Conversation
4121860 to
362d341
Compare
There was a problem hiding this comment.
LGTM. Canonical Changesets release PR — version math, CHANGELOG, and shim pin all line up with the consumed changeset.
Things I checked
- Version bump: 7.11.2 → 7.11.3 is the correct
patchincrement for the singlepatchchangeset (.changeset/proposal-gate-absence.md). No version skipped, no manual edit. - CHANGELOG entry under
## 7.11.3mirrors the changeset prose verbatim and credits2b2086c— the underlying fix landed onbackport-2114-adcp-3.0already. - Consumed changeset deleted (
.changeset/proposal-gate-absence.md) — expected. packages/client-shim/package.jsondep pin moves to^@adcp/sdk@^7.11.3in lockstep — no stale pin left behind.- Base is
backport-2114-adcp-3.0, notmain— this is the 3.0 backport release line, not the primary trunk. Worth a glance to confirm intent, but the changeset/version math is self-consistent against that branch. - CI:
check / check,commitlint, GitGuardian all green.
Merge to fire the publish workflow.
Safe to merge.
There was a problem hiding this comment.
Standard Changesets release PR — mechanical and correct. Version is owned by changesets, not edited by hand, which is exactly the contract CLAUDE.md requires.
Things I checked
- Version math:
7.11.2+ thepatchchangeset =7.11.3. No skipped version. (package.json:3) - The
package.jsonbump is changesets-generated, not a manual edit — accompanied by the consumed.changeset/proposal-gate-absence.mddeletion. Not a MUST FIX #6. - CHANGELOG entry mirrors the deleted changeset verbatim, including the
2b2086ccommit reference. (CHANGELOG.md:3-12) packages/client-shimdependency bumped in lockstep:^7.11.2→^7.11.3. No version drift between workspace packages.- No source changes —
src/lib/**,bin/**,scripts/**untouched. Triage: release-only, experts skipped.
Underlying fix 2b2086c (treat absent supports_proposals as unsupported) is a patch — fail-closed on an omitted capability gate, which is the right shape. That review happened on its own PR; nothing to re-litigate here.
Safe to merge once CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to backport-2114-adcp-3.0, this PR will be updated.
Releases
@adcp/sdk@7.11.3
Patch Changes
2b2086c: fix(conformance): skip proposal storyboards when supports_proposals is absent
Treat omitted
media_buy.supports_proposalsas unsupported for proposal lifecyclerequires_capabilitygates, including profiles without raw capabilities.