fix: run advertised sync_accounts in storyboards#2311
Conversation
|
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final This is an automated message from the Argus AI review workflow. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00fb36e9a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (rawCaps !== undefined) { | ||
| const requireOperatorAuth = resolveCapabilityPath(rawCaps, 'account.require_operator_auth'); | ||
| if (requireOperatorAuth === true) { | ||
| const syncAccountsAdvertised = options.agentTools?.includes('sync_accounts') === true; |
There was a problem hiding this comment.
Use discovered tools in the sync_accounts gate
When runStoryboardStep() is used without an explicit agentTools option, it still discovers the agent profile and stores it in options._profile, but it does not copy _profile.tools into options.agentTools. In that standalone-step path, an explicit-mode seller that advertises sync_accounts in discovery is treated as not advertised here and the step is skipped as not_applicable, so the new behavior only works for full storyboard runs or callers that redundantly pass agentTools. Use the existing _profile.tools fallback (e.g. resolveAdvertisedTools(options)) for this check.
Useful? React with 👍 / 👎.
bokelley
left a comment
There was a problem hiding this comment.
Reviewed the runner change and regression coverage. The new behavior is scoped correctly: explicit-account sellers still get marked not_applicable when they do not advertise the tool, but sellers that explicitly advertise now run the step. Full CI is green and the patch changeset is present.
Summary
sync_accountsskip so it only applies when the agent does not advertisesync_accounts.not_applicablecascade behavior for explicit-mode sellers that omit the tool.sync_accountsactually run the step.Fixes #2303.
Validation
npm run build:libNODE_ENV=test node --test-timeout=60000 --test test/lib/storyboard-cascade-skip-on-skip.test.jsNODE_ENV=test node --test-timeout=60000 --test test/server-decisioning-capability-projections.test.jsgit diff --check