chore: release package#2323
Merged
Merged
Conversation
ae8d2b9 to
8aa979c
Compare
bokelley
approved these changes
Jul 6, 2026
bokelley
left a comment
Contributor
There was a problem hiding this comment.
Generated registry output refreshed for release CI drift.
There was a problem hiding this comment.
Standard changesets release PR — approving on version coherence plus a justified major bump. This is right because the version field is changeset-owned, not hand-edited, and the calc lands exactly where the major changeset says it should.
Things I checked
package.json9.7.0 → 10.0.0 is driven by themajorchangeset (tidy-webhooks-tenant-isolation.md— webhook default flips tocreatePinAndBindFetch()), not a manual edit. Not a MUST FIX #6.- No version skip: npm is at 9.7.0, one
majorchangeset → 10.0.0. - Version constants agree everywhere —
package.json,package-lock.json(both root entries), andsrc/lib/version.ts(LIBRARY_VERSION+VERSION_INFO.library) all read10.0.0.ADCP_VERSIONcorrectly left at3.1.1(independent of library version). - Workspace deps bumped in lockstep: client-shim
^9.7.0→^10.0.0, eslint-plugin dep^9.0.0→^10.0.0, eslint-plugin itself 0.1.3 → 0.1.4 (patch, dependency-only). - CHANGELOG entry matches the two consumed changesets (major security/breaking + minor registry regen); both
.changeset/*.mdfiles correctly deleted. - Second commit (
sync release registry types) only reorders theBrandEventPayloadblock earlier inregistry.yamlandsrc/lib/registry/types.generated.ts— same fields, same shape, no wire change.
Minor nits (non-blocking)
- Regen reorder rode in on the release PR. The
BrandEventPayloadmove is a pure codegen ordering artifact committed directly onto the release branch rather than through its own changeset — harmless since it's already covered by the68ce3f4minor entry, but notable that a hand-pushed commit landed on an automated release PR.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@adcp/sdk@10.0.0
Major Changes
fc18b40: Security: webhook emitter is SSRF-safe by default, and
createTenantStoregains an opt-inresolveisolation gate.Breaking — webhook delivery default.
createWebhookEmitter/createAdcpServer({ webhooks })now default their HTTP client tocreatePinAndBindFetch()instead ofglobalThis.fetch. This defeats DNS-rebinding / SSRF against the buyer-suppliedpush_notification_config.url(https-only; loopback, private, and cloud-metadata ranges denied). In-process harnesses that deliver to a loopbackhttp://127.0.0.1receiver must now opt in explicitly:Passing
fetch: globalThis.fetchrestores the previous unguarded behavior (only do so behind your own URL validation).createTenantStore—refAccessgate onresolve. AddedrefAccess?: 'ref-routed' | 'auth-scoped'(default'ref-routed', non-breaking).'ref-routed'preserves the agency-hub model where one credential may resolve any tenant's account by ref.'auth-scoped'makesaccounts.resolvefail closed when a buyer-supplied ref points at a tenant other than the authenticated principal's — closing a cross-tenant read/mutate path for non-trusted-buyer deployments. Corrected thecreateTenantStore/account.tsdocs, which previously impliedresolvewas always an isolation gate; it is not unlessrefAccess: 'auth-scoped'is set or aresolve-presetsguard is composed.Minor Changes
68ce3f4: Regenerate the bundled AdCP registry OpenAPI spec and generated TypeScript types from the latest hosted registry schema.
This adds typed registry feed event payloads plus catalog browse/sync response types to the public registry type exports.
@adcp/eslint-plugin@0.1.4
Patch Changes