Skip to content

Migrate conductor.json to .conductor/settings.toml#2346

Merged
bokelley merged 1 commit into
mainfrom
conductor/migrate-to-settings-v2-adcp-client-1
Jul 9, 2026
Merged

Migrate conductor.json to .conductor/settings.toml#2346
bokelley merged 1 commit into
mainfrom
conductor/migrate-to-settings-v2-adcp-client-1

Conversation

@bokelley

@bokelley bokelley commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This PR migrates the legacy conductor.json configuration to the new .conductor/settings.toml format.

Generated by Conductor.

@aao-ipr-bot aao-ipr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight config migration — conductor.json.conductor/settings.toml, setup script moved verbatim. Dev tooling, not published, so no changeset owed and nothing on the wire changes.

Things I checked

  • Setup script value is byte-identical between the old JSON and new TOML — same git fetch/rebase, same cp $CONDUCTOR_ROOT_PATH/.env ., same npm installsync-schemasgenerate-types sequence. Migration only, no behavior change.
  • .npmignore:133-134 already ignores both conductor.json and .conductor/, so the new file stays out of the @adcp/sdk tarball. No published-package impact.
  • No changeset required — CLAUDE.md:133 lists conductor.json explicitly under no-changeset dev tooling, and this touches nothing in src/lib/**, bin/**, or package.json's files field.
  • Only other conductor.json reference is prose in CLAUDE.md's no-changeset list — not a blob/main/ link, so ci:doc-links is unaffected.

Minor nits (non-blocking)

  1. Stale prose reference. CLAUDE.md:133 still names conductor.json in the no-changeset list. Harmless — the rule applies equally to .conductor/. Worth a one-word update next time that section is touched.

LGTM.

@bokelley bokelley merged commit 620a6c8 into main Jul 9, 2026
29 of 31 checks passed
@bokelley bokelley deleted the conductor/migrate-to-settings-v2-adcp-client-1 branch July 9, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant