Migrate conductor.json to .conductor/settings.toml#2346
Merged
Conversation
There was a problem hiding this comment.
Straight config migration — conductor.json → .conductor/settings.toml, setup script moved verbatim. Dev tooling, not published, so no changeset owed and nothing on the wire changes.
Things I checked
- Setup script value is byte-identical between the old JSON and new TOML — same
git fetch/rebase, samecp $CONDUCTOR_ROOT_PATH/.env ., samenpm install→sync-schemas→generate-typessequence. Migration only, no behavior change. .npmignore:133-134already ignores bothconductor.jsonand.conductor/, so the new file stays out of the@adcp/sdktarball. No published-package impact.- No changeset required — CLAUDE.md:133 lists
conductor.jsonexplicitly under no-changeset dev tooling, and this touches nothing insrc/lib/**,bin/**, orpackage.json'sfilesfield. - Only other
conductor.jsonreference is prose in CLAUDE.md's no-changeset list — not ablob/main/link, soci:doc-linksis unaffected.
Minor nits (non-blocking)
- Stale prose reference. CLAUDE.md:133 still names
conductor.jsonin the no-changeset list. Harmless — the rule applies equally to.conductor/. Worth a one-word update next time that section is touched.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the legacy
conductor.jsonconfiguration to the new.conductor/settings.tomlformat.Generated by Conductor.