Skip to content

chore: regen types from latest AdCP schemas (idempotency_key)#628

Merged
bokelley merged 1 commit into
mainfrom
bokelley/sync-schemas
Apr 19, 2026
Merged

chore: regen types from latest AdCP schemas (idempotency_key)#628
bokelley merged 1 commit into
mainfrom
bokelley/sync-schemas

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

Every PR has been failing the Validate generated files are in sync check because upstream AdCP schemas drifted. This PR regenerates core.generated.ts and schemas.generated.ts against the current upstream bundle.

Upstream changes picked up

  • RevocationNotification.notification_ididempotency_key
  • MCPWebhookPayload — adds required idempotency_key
  • ArtifactWebhookPayload — adds required idempotency_key
  • CollectionListChangedWebhook — adds required idempotency_key
  • PropertyListChangedWebhook — adds required idempotency_key

Upstream consolidated webhook dedup onto a single canonical key scoped to the authenticated sender identity.

Blast radius

  • Published type signatures change — consumers populating or reading RevocationNotification.notification_id must rename to idempotency_key.
  • No runtime code changes; no uses of the renamed field exist in src/.
  • Unblocks chore: regenerate package-lock.json to unblock release workflow #626 and every other PR (the sync check runs on all of them).

Changeset: minor (published types changed).

🤖 Generated with Claude Code

Upstream renamed RevocationNotification.notification_id →
idempotency_key and added required idempotency_key to
MCPWebhookPayload, ArtifactWebhookPayload, and the two
*ListChangedWebhook payloads. Receivers dedupe by this key
scoped to sender identity.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley
bokelley merged commit b4709ad into main Apr 19, 2026
14 checks passed
bokelley added a commit that referenced this pull request Apr 19, 2026
Picks up GetAdCPCapabilitiesResponse.experimental_features and other
drift that landed after #628's regen.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Apr 19, 2026
* chore: regenerate package-lock.json

Fixes release workflow failure — npm ci complained about missing
@esbuild/* optional platform packages. Someone committed a lock
generated with only the local platform's esbuild binary, so CI (Linux)
couldn't resolve the tree. Regenerated from a clean node_modules.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: add empty changeset (lock-file only)

Changeset check requires either a version-bumping changeset or an
explicit empty one. This PR only regenerates package-lock.json to
restore cross-platform esbuild entries, so no release is needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(generated): refresh types (experimental_features, misc upstream)

Picks up GetAdCPCapabilitiesResponse.experimental_features and other
drift that landed after #628's regen.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant