chore(types): regen against latest upstream AdCP schemas#635
Closed
bokelley wants to merge 1 commit into
Closed
Conversation
Purely additive. The CI "Validate generated files are in sync" check was failing on main because the upstream protocol bundle advanced past the committed generated types. Ran: npm run sync-schemas npm run generate-types npm run generate-wellknown-schemas Surfaces new optional capability fields — `webhook_signing` (RFC 9421 outbound-webhook profile), `identity` (operator key-scoping posture), `account_id_is_opaque` on `IdempotencySupported`, `aggregation_window_days` on the governance capability, and a few downstream `targeting_overlay` / related additions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as redundant — PR #624 (docs(skills)) silently bundled the identical type regen (176/5 diff, same additive capability fields). Main's CI is unblocked via #624, so this PR adds no content beyond a duplicate changeset describing work already shipped. Rebasing #502 onto current main to pick up the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/types/{core,tools,schemas}.generated.tsagainst the latest upstream AdCP protocol bundle.webhook_signing,identity,account_id_is_opaque,aggregation_window_days,targeting_overlay) are already present in the upstream bundle but weren't reflected in the committed generated types.main— the "Validate generated files are in sync" step has been failing since the upstream bundle advanced (e.g., run 24650174615 on test(storyboard-drift): drop stale idempotency.supported skip #633's merge commit). All open PRs are inheriting that failure.Test plan
npm run typecheck— passesnpm run build— passesTest & Build,Code Quality,Security Audit,commitlint, changeset check) — will run on this PRFollow-up
🤖 Generated with Claude Code