fix(storyboard): emit unresolved_hidden_by_pagination meta-observation (#718)#733
Merged
Conversation
#718) When refs_resolve sees target_paginated AND at least one ref was demoted to unresolved_with_pagination, emit a neutral structural flag so graders can detect sellers indefinitely returning `has_more: true` to hide refs they can't service. Pass/fail semantics preserved — graders interpret the flag. Payload mirrors scope_excluded_all_refs: `{ kind, unresolved_count }`. unresolved_count is deduped so it matches the per-ref observation count. Becomes redundant when adcp#2601's "compliance mode returns everything referenced in a single response" rule lands at the spec level. Reviewed by code-reviewer (ship it, nice-to-have dedup test added) and ad-tech-protocol-expert (rename from pagination_bypass_suspected to unresolved_hidden_by_pagination — neutral descriptor matches precedent set by target_paginated/scope_excluded_all_refs, not accusatory). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ypass-obs # Conflicts: # src/lib/types/core.generated.ts # src/lib/types/schemas.generated.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #718. When
refs_resolveseestarget_paginatedAND at least one ref was demoted tounresolved_with_pagination, the validator now emits a newunresolved_hidden_by_paginationmeta-observation so graders can detect sellers indefinitely returningpagination.has_more: trueto hide refs they can't service. Pass/fail semantics unchanged — graders interpret the flag.Catches the integrity gap introduced by #717's pagination demotion: a seller that unconditionally returns
has_more: truemasks unresolved refs, and graders keying onrefs_resolve.passedalone miss the structural smell. The new observation gives compliance dashboards an independent grader signal.Design
Payload mirrors
scope_excluded_all_refs:{ kind, unresolved_count }. The per-ref detail already lives in theunresolved_with_paginationobservations emitted immediately after — duplicating refs would inflate cap pressure without adding signal.unresolved_countis deduped so it matches the per-ref observation count.Naming is neutral (
unresolved_hidden_by_pagination) to match sibling observations (target_paginated,scope_excluded_all_refs,non_object_values_filtered). The validator names structural smells; graders decide intent.Reviewer passes
Run through
code-reviewerandad-tech-protocol-expert. Feedback addressed:pagination_bypass_suspected→unresolved_hidden_by_pagination(protocol-expert: smuggles accusation into the observation shape; sibling observations are all neutral descriptors)unresolved_countand per-refunresolved_with_paginationobservations (code-reviewer)adcp#2601as the spec-level sunset condition (protocol-expert)Test plan
npm test— all suites passnode --test test/lib/storyboard-validations-refs-resolve.test.js— 43/43 pass (4 new)passedstays trueunresolved_countreports deduped refs, not raw occurrences🤖 Generated with Claude Code