chore: regenerate types from latest AdCP schema tarball#767
Closed
bokelley wants to merge 3 commits into
Closed
Conversation
…criminator Schemas regenerated from upstream now require an `asset_type` discriminator on every creative asset and `action` on each per-creative sync_creatives response item. Updates: - `src/lib/conformance/seeder.ts` ASSET_PLACEHOLDER — emit `asset_type` on every placeholder so seeded creatives pass the strict response-validation surface default in dev/test. - `test/lib/conformance-seeder.test.js` — mock handler returns `action`, assertion expects `asset_type` on the synthesized text asset. - `test/lib/request-validation.test.js` — video asset fixtures include `asset_type: 'video'`. - `test/lib/zod-schemas.test.js` — GetCreativeFeatures fixture uses the new image-asset shape (`asset_type`, `width`, `height`). Plus a changeset covering the regen itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Previous push didn't fire pull_request-event workflows. Empty commit to nudge CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as superseded. PR #762 (merged 2026-04-22T02:55Z) already included the upstream schema regen ( Matrix v12 unblock was handled via #762. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine type regen after upstream schema sync.
npm run typecheckclean;npm testexpected clean (runs in CI).Unblocks matrix v12 — CI's "Validate generated files" fails on any branch with stale generated types, so landing this before the matrix keeps the failing-pair baseline clean.