fix: include all bin JS files in npm package#77
Merged
Conversation
The CLI tool requires bin/adcp-async-handler.js but it wasn't being included in the published package, causing 'Cannot find module' errors. Changed package.json files field from 'bin/adcp.js' to 'bin/**/*.js' to include all JavaScript files in the bin directory. Fixes error: Error: Cannot find module './adcp-async-handler.js'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI tool published in v2.4.0 is broken:
Root Cause
The
package.jsonfiles field only includedbin/adcp.jsbut the CLI requiresbin/adcp-async-handler.jswhich wasn't being published.Solution
Changed the files field from:
"bin/adcp.js"To:
"bin/**/*.js"This ensures all JavaScript files in the bin directory are included in the published package.
Testing
Verified with
npm pack --dry-run:Both files are now included.
Impact