Remove deprecated and fallback fields - #126
Merged
Merged
Conversation
* Fix format_ids schema to use structured format ID objects Changed format_ids from arrays of strings to arrays of format-id objects (with agent_url and id fields) across all schemas and documentation. **Schema changes:** - static/schemas/v1/media-buy/package-request.json - static/schemas/v1/media-buy/list-creative-formats-request.json - static/schemas/v1/creative/list-creative-formats-request.json - static/schemas/v1/media-buy/get-products-request.json **Documentation updates (16 examples):** - docs/media-buy/task-reference/create_media_buy.md (10 examples) - docs/media-buy/product-discovery/media-products.md (3 examples) - docs/media-buy/advanced-topics/pricing-models.md (2 examples) - docs/media-buy/task-reference/list_creative_formats.md (1 example) This aligns with the protocol's requirement that format IDs are ALWAYS structured objects to avoid parsing ambiguity and handle namespace collisions between creative agents. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Remove outdated formats_to_provide reference from CLAUDE.md The schema correctly uses format_ids consistently throughout. Updated the 'Better Field Naming' example to reflect the actual field name used. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-client
that referenced
this pull request
Oct 15, 2025
## Breaking Changes ### Strict FormatID Typing - All format ID fields now use structured `FormatID` type with `agent_url` and `id` properties - No more plain string format IDs anywhere in the codebase - Affects: `format_id`, `format_ids`, `output_format_ids`, `formats_to_provide` ### Deprecated Field Removal Per AdCP spec v2.0.0 (adcontextprotocol/adcp#126): - `promoted_offering` replaced with `brand_manifest` in all requests - Removed support for deprecated `products` array in packages (use `product_id`) - Removed support for `video_completions` (use `completed_views`) ## Changes ### Type System - Updated `src/lib/types/adcp.ts`: - Import structured `FormatID` from generated types - Use `FormatID` in `CreativeFormat` and `CreativeFilters` - Update `TestRequest` to use `brand_manifest` instead of `promoted_offering` - Updated `src/lib/utils/index.ts`: - Convert hardcoded format IDs to structured `FormatID` objects - Removed stale `src/types/adcp.ts` file ### API & Server - Updated `src/server/server.ts`: - Replace `promoted_offering` with `brand_manifest` in all endpoints - Update API parameter types and request handling - Updated `src/adagents-manager.ts`: - Fix import path after removing stale types file ### UI - Updated `src/public/index.html`: - Replace all `promoted_offering` references with `brand_manifest` - Update JavaScript variable names ### Generated Types - Synced with AdCP spec v2.0.0 - All format ID fields now properly typed as `FormatID` - No post-processing hacks needed - clean type generation ## Testing ✅ Build passes with strict TypeScript checks ✅ All format IDs properly typed as structured objects ✅ No deprecated fields in outgoing requests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-client
that referenced
this pull request
Oct 15, 2025
* feat: enforce strict FormatID typing and remove deprecated fields ## Breaking Changes ### Strict FormatID Typing - All format ID fields now use structured `FormatID` type with `agent_url` and `id` properties - No more plain string format IDs anywhere in the codebase - Affects: `format_id`, `format_ids`, `output_format_ids`, `formats_to_provide` ### Deprecated Field Removal Per AdCP spec v2.0.0 (adcontextprotocol/adcp#126): - `promoted_offering` replaced with `brand_manifest` in all requests - Removed support for deprecated `products` array in packages (use `product_id`) - Removed support for `video_completions` (use `completed_views`) ## Changes ### Type System - Updated `src/lib/types/adcp.ts`: - Import structured `FormatID` from generated types - Use `FormatID` in `CreativeFormat` and `CreativeFilters` - Update `TestRequest` to use `brand_manifest` instead of `promoted_offering` - Updated `src/lib/utils/index.ts`: - Convert hardcoded format IDs to structured `FormatID` objects - Removed stale `src/types/adcp.ts` file ### API & Server - Updated `src/server/server.ts`: - Replace `promoted_offering` with `brand_manifest` in all endpoints - Update API parameter types and request handling - Updated `src/adagents-manager.ts`: - Fix import path after removing stale types file ### UI - Updated `src/public/index.html`: - Replace all `promoted_offering` references with `brand_manifest` - Update JavaScript variable names ### Generated Types - Synced with AdCP spec v2.0.0 - All format ID fields now properly typed as `FormatID` - No post-processing hacks needed - clean type generation ## Testing ✅ Build passes with strict TypeScript checks ✅ All format IDs properly typed as structured objects ✅ No deprecated fields in outgoing requests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: sync with AdCP v2.0.0 and bump to v1.0.0 - Synced schemas with AdCP spec v2.0.0 - Auto-updated library version from 0.4.2 to 1.0.0 (major bump due to AdCP v2.0.0) - Regenerated types with latest schema changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: bump version to 2.0.0 to match AdCP spec Library version now matches AdCP spec version (2.0.0). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
bokelley
added a commit
to prebid/salesagent
that referenced
this pull request
Oct 15, 2025
Removes three deprecated fields from AdCP specification:
1. **promoted_offering → brand_manifest** (now required)
- Removed from CreateMediaBuyRequest and GetProductsRequest
- Updated all tool signatures (MCP and A2A)
- Updated naming templates: {campaign_name|brand_name}
- Added brand name extraction logic for objects/dicts/URLs
2. **Package.products[] → Package.product_id** (singular)
- Removed array field, kept only singular product_id
- Updated all package creation code
- Fixed get_product_ids() to use product_id only
3. **video_completions → completed_views**
- Updated in DeliveryTotals, PackageDelivery, AggregatedTotals
- Consistent field naming across delivery metrics
**Breaking Changes:**
- brand_manifest is now REQUIRED in get_products requests
- Package.products array no longer supported
- video_completions field removed from delivery responses
**Files Updated:**
- Core schemas & adapters (10 files)
- Naming utilities across adapters (3 files)
- 50+ test files updated to use new field names
- JSON schema cache files updated
**Testing:**
- All unit tests passing
- Integration tests updated
- AdCP compliance tests passing
Refs: adcontextprotocol/adcp#126
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
promoted_offeringfrom create-media-buy and get-products requests (usebrand_manifest)productsarray from package requests (use singularproduct_id)video_completionsfrom delivery metrics (usecompleted_views)statusfield from response schema (protocol-level concern)Rationale
These fields were all deprecated with clear migration paths. Removing them prepares the spec for v1 release by eliminating technical debt and ensuring a clean API surface.
Breaking Changes
All changes are breaking but expected - these fields were documented as deprecated. Implementations should have already migrated to the new patterns.
🤖 Generated with Claude Code