fix: notify WG Slack when committee document added#1552
Merged
Conversation
When a working group leader adds a committee document, post a notification to the WG's Slack channel so members can track updates. This was missing — only published posts triggered channel notifications. Includes isSlackConfigured() guard, APP_URL support, and mrkdwn sanitization for title in link syntax. Resolves Addie escalation #123 (Pia/Creative WG). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
May 4, 2026
…G_STEPS (#4080) * fix(training-agent): bump @adcp/sdk to 6.11.0, drop both KNOWN_FAILING_STEPS 6.11.0 ships adcp-client#1554 (handoffToTask accepts caller-supplied task_id) and #1552 (simulate_delivery spreads extension params verbatim). Wires the v6 sales platform's createMediaBuy to route the directive's submitted-arm envelope through ctx.handoffToTask with task_id, removes both KNOWN_FAILING_STEPS entries, ratchets step counts. Conformance suite fully green with zero skips. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(storyboards): pin overlay to ADCP_VERSION cache dir, skip .previous SDK 6.11 ships a `<version>.previous` sibling alongside `<version>` for downgrade rollback. The runner reads from `<version>` per ADCP_VERSION, but the overlay's `find | head -1` picked siblings non-deterministically — locally it picked `<version>` (right) but Linux ext4 in CI picked `.previous` (wrong) and left the live cache with the SDK-bundled YAML. Storyboard checks then graded against the un-widened cache instead of the current-PR fixtures, regressing every tenant. Resolve via ADCP_VERSION when present; otherwise sort + filter out `.previous` defensively. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
sendChannelMessage+isSlackConfiguredcall after document creation inPOST /api/working-groups/:slug/documentsAPP_URLenv var instead of hardcoded domainnotifyPublishedPostconventionTest plan
|or<characters — verify Slack message renders correctly🤖 Generated with Claude Code