refactor: route brand protocol tools through training agent#1618
Merged
Conversation
Brand sandbox tools (sandbox_get_brand_identity, sandbox_get_rights, sandbox_acquire_rights, sandbox_update_rights) were custom Addie tools with a bespoke interface. This refactors them into standard AdCP tools (get_brand_identity, get_rights, acquire_rights, update_rights) that route through the training agent, matching the pattern used by media buy, creative, signals, and governance tools. - Move seed data and handlers to training-agent/brand-handlers.ts - Add ADCP_BRAND_PROTOCOL_TOOLS to adcp-tools.ts with agent_url routing - Wire brand handlers into training agent HANDLER_MAP and TOOLS - Update tool-sets.ts (certification + adcp_operations) - Migration to rename tool references in C2 exercise definitions - Fix in-process shortcut hostname check (security review finding) - Delete brand-sandbox-tools.ts and all references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Mar 22, 2026
Resolve merge conflicts in task-handlers.ts: - Incorporate proposal-based creation from main (#1618) - Add proposal completion logic to handleGetProducts - Fix type compatibility (Product vs Partial<Product>) - Fix SpecialCategory type derivation for @adcp/client compat Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox_get_brand_identity,sandbox_get_rights,sandbox_acquire_rights,sandbox_update_rights) were custom Addie tools with a bespoke interface that didn't match the AdCP protocol surfaceget_brand_identity,get_rights,acquire_rights,update_rights) that route through the training agent viaagent_url, matching the pattern used by media buy, creative, signals, and governance toolsChanges
server/src/training-agent/brand-handlers.ts— seed data + handlers (ported from deleted file)server/src/db/migrations/313_c2_brand_tools_rename.sql— renames tool refs in C2 exercisesadcp-tools.ts— addsADCP_BRAND_PROTOCOL_TOOLSwithagent_urlroutingtask-handlers.ts— wires brand handlers into training agent dispatchtool-sets.ts— updates certification + adcp_operations setsbrand-sandbox-tools.ts+ all references in bolt-app.ts, register-baseline-tools.tsTest plan
🤖 Generated with Claude Code