docs: add schema links to preview_creative reference#1777
Merged
Conversation
Add Request Schema and Response Schema links pointing to the v3 versioned schemas, matching the pattern used by other creative task references.
Contributor
Schema Link Check ResultsCommit:
|
nastassiafulconis
approved these changes
Mar 31, 2026
5 tasks
bokelley
added a commit
that referenced
this pull request
May 17, 2026
…ore/authorized-agent-base.json (closes #4510) (#4610) * refactor(adagents): extract shared authorized_agents[*] fields into core/authorized-agent-base.json Closes #4510. Previously deferred because adcp-client TS codegen (json-schema-to-typescript) produced broken union types on `allOf+$ref` patterns. Unblocked by adcp-client#1756 (PRs #1777 / #1783 — pre-merge pass that flattens `allOf+$ref` siblings before codegen). Five fields shared across all six authorized_agents[*] variants — url, authorized_for, signing_keys, encryption_keys, last_updated — move into core/authorized-agent-base.json. Each variant now allOfs the base alongside its variant-specific properties. Discriminator-specific fields (authorization_type const + the variant selector) and property-variant qualifiers (collections, placement_ids, placement_tags, delegation_type, exclusive, countries, effective_*) stay at the variant root so audit-oneof's discriminator detection keeps working. No semantic change — the bundled schema permits the same inputs. Existing files validate unchanged. Codegen verified: - Python (datamodel-codegen): clean inheritance, AuthorizedAgents1..6(AuthorizedAgentBase). Field duplication across six variants eliminated. - TS (json-schema-to-typescript): adcp-client's just-shipped pre-merge pass handles allOf+$ref. End-to-end verification after they regen. Drift prevention: adding a new shared field requires one schema edit instead of six (cf. last_updated in PR #4504, which had to be added six times). Tests: - audit-oneof --check: ok (37 -> 39 discriminated; new base classified cleanly). - composed-schema-validation: 43/43 pass. - example-validation: 14/14 adagents-relevant pass. - Bundled schemas include the new base file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(adagents): neutralize base-schema descriptions per protocol-review Expert review on PR #4610. Protocol expert's only should-fix: Pre-refactor, signal_ids/signal_tags variants had distinct prose for url + authorized_for ("authorized signals agent's API endpoint URL" / "what signals this agent is authorized to resell"). The first-cut base collapsed those into property-flavored descriptions, leaving signal-side codegen docstrings reading wrong. Neutralized the base-level descriptions to fit both audiences: - url: refer to registries generically ("sales-agent list, signal- provider registry, TMP provider lookup") instead of just TMP/property. - authorized_for: name both inflections (sells / provides) and pin the variant choice as the discriminator. Plus code-reviewer's nit: dropped "(4 property + 2 signal)" count from the base description — phrasing was prone to staleness if a 7th variant lands. audit-oneof, composed-schema-validation, build all unchanged (39 discriminated; 43/43 tests pass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preview_creativetask reference pageget_creative_delivery,list_creative_formats, etc.)Test plan
npm run buildpasses