feat: promote 4 protocol storyboards to canonical definitions#2002
Merged
Conversation
…efinitions Add 4 storyboards that define protocol compliance requirements: - schema_validation: response schema conformance + temporal constraints - behavioral_analysis: brief filtering, response consistency, pricing edge cases - error_compliance: error codes, recovery hints, transport bindings (L1/L2/L3) - media_buy_state_machine: state transitions + terminal state enforcement These were developed in @adcp/client but describe agent behavior requirements, not client internals. The adcp repo is the canonical source for protocol storyboards; @adcp/client will pull from here. Also updates PLATFORM_STORYBOARDS to include the new storyboards for all sales platforms (schema_validation, behavioral_analysis, error_compliance, media_buy_state_machine where applicable). 25 storyboards total. brand_rights already existed from #1985. deterministic_testing stays in @adcp/client (test harness, not protocol). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…board tests - Add media_buy_state_machine to all media-buy-capable platforms (retail_media, search_platform, audio_platform, ai_ad_network, social_platform) - Add behavioral_analysis and error_compliance to ai_platform - Add per-storyboard test blocks for schema_validation, behavioral_analysis, error_compliance, and media_buy_state_machine Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All 25 storyboards now include: - track: compliance track for grouping results (core, products, media_buy, etc.) - required_tools: tools the agent must advertise for the storyboard to run - platform_types: (where applicable) which platform types this storyboard applies to These fields are required by @adcp/client's loader functions (getStoryboardsForPlatformType, getComplianceStoryboardsForTrack). Without them, the client cannot filter or group storyboards. Also updates the Storyboard TypeScript interface to include the new fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This mapping will move to @adcp/client once adcp-client#445 ships storyboard-based comply(). Callers will pass platform_type to comply() and let the client resolve storyboards internally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rom main + track/required_tools from branch) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes 4 protocol compliance storyboards from
@adcp/clientto canonical definitions in the adcp repo. These describe agent behavior requirements per the AdCP spec — they belong here, not in the client.New storyboards (4):
schema_validation— response schema conformance + temporal constraint enforcementbehavioral_analysis— brief filtering behavior, response consistency, pricing edge caseserror_compliance— error codes, recovery hints, L1/L2/L3 transport bindingsmedia_buy_state_machine— state transitions (pause/resume/cancel) + terminal state enforcementUpdated
PLATFORM_STORYBOARDS— sales platforms now includeschema_validation,behavioral_analysis,error_compliance, andmedia_buy_state_machinewhere applicable.25 total storyboards in the canonical set.
deterministic_testingstays in@adcp/clientas test harness infrastructure.Storyboard inventory after this PR
Follow-up
@adcp/clientPR #445 should pull storyboard YAMLs from this repo rather than maintaining its own copies. The canonical set lives here; the client addsdeterministic_testingas a client-specific overlay.Test plan
🤖 Generated with Claude Code