fix: Restore offline file delivery section, update pre commit hook from Docusaurus to Mintlify build check#215
Merged
Conversation
…atible tabs - Restore the Offline File Delivery (Batch) section that was removed in PR #203 - Use Mintlify-compatible Tabs syntax (production system) - Add comprehensive examples for JSONL, CSV, and Parquet formats - Fixes empty space issue at #offline-file-delivery-batch anchor Note: Uses Mintlify syntax for production deployment. Pre-commit Docusaurus build may need adjustment.
Production uses Mintlify, not Docusaurus. Docusaurus build fails on Mintlify-specific syntax like <Tab> components. This allows Mintlify-compatible documentation to be pushed without build failures.
Replace Docusaurus build with Mintlify validation: - Check for broken internal links (fails on errors) - Check for accessibility issues (warns only) This ensures documentation is valid for Mintlify (production system) before pushing.
…nation - Use dot notation for nested CSV columns (e.g., by_package.pricing_model, totals.impressions) - Simplify CSV section to focus on unnesting to by_package level - Remove multi-level nesting references - Update examples to match industry-standard dot notation format
…xamples - Move Delivery Methods to parent section with Webhook-Based Reporting and Offline-File-Delivery-Based Reporting as subsections - Move webhook-related sections (Privacy, Implementation Best Practices, Webhook Health Monitoring) under Webhook-Based Reporting - Move Offline-File-Delivery-Based Reporting section before Data Reconciliation - Add notification_type, sequence_number, and next_expected_at fields to all offline file format examples (JSONL, CSV, Parquet) - Remove 'Recommended for most use cases' from JSONL section - Update CSV format to use dot notation (by_package.pricing_model, totals.impressions)
igorantun
approved these changes
Nov 18, 2025
nastassiafulconis
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the "Offline File Delivery (Batch)" section that was removed in PR #203 and updates the pre-push validation to use Mintlify instead of Docusaurus.
#offline-file-delivery-batchanchorDocumentation Fixes
TabItemto Mintlify<Tab>syntax#offline-file-delivery-batchanchorInfrastructure Changes
Technical Details
Why it was removed before:
TabItemsyntax caused MDX parsing errors in MintlifySolution:
<Tab>components (no imports needed)Test Plan
Files Changed
docs/media-buy/media-buys/optimization-reporting.mdx- Restored section with Mintlify-compatible tabs (+129 lines).husky/pre-push- Updated validation to use Mintlify instead of Docusaurus