Add artifactId to A2A documentation examples#249
Merged
Conversation
Fix A2A protocol compliance issues in documentation by adding missing artifactId fields and correcting request structure. **Changes:** - Add artifactId to all 11 A2A artifact examples across 8 files - Fix skill invocation: use 'parameters' not 'input' (3 instances) - Fix message structure: wrap in message.parts[] envelope (5 instances) - Fix webhook config: move to configuration.pushNotificationConfig (2 instances) **Why this matters:** - artifactId is part of A2A protocol for artifact identification/versioning - Correct field names ensure examples work when developers copy them - Proper message structure matches A2A specification **Files modified:** - docs/media-buy/advanced-topics/orchestrator-design.mdx - docs/media-buy/task-reference/create_media_buy.mdx - docs/media-buy/task-reference/provide_performance_feedback.mdx - docs/protocols/a2a-guide.mdx - docs/protocols/envelope-examples.mdx - docs/protocols/getting-started.mdx - docs/protocols/protocol-comparison.mdx - docs/signals/tasks/activate_signal.mdx - docs/signals/tasks/get_signals.mdx Incorporates fixes from PR #231 by @EmmaLouise2018. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts by accepting refactored create_media_buy.mdx from main. The new version focuses on testable code examples and removes redundant A2A-specific examples (those details are now in dedicated A2A guide docs). Kept our artifactId additions in other A2A documentation files.
bmilekic
pushed a commit
to bmilekic/adcp
that referenced
this pull request
Dec 5, 2025
* Add artifactId to A2A documentation examples Fix A2A protocol compliance issues in documentation by adding missing artifactId fields and correcting request structure. **Changes:** - Add artifactId to all 11 A2A artifact examples across 8 files - Fix skill invocation: use 'parameters' not 'input' (3 instances) - Fix message structure: wrap in message.parts[] envelope (5 instances) - Fix webhook config: move to configuration.pushNotificationConfig (2 instances) **Why this matters:** - artifactId is part of A2A protocol for artifact identification/versioning - Correct field names ensure examples work when developers copy them - Proper message structure matches A2A specification **Files modified:** - docs/media-buy/advanced-topics/orchestrator-design.mdx - docs/media-buy/task-reference/create_media_buy.mdx - docs/media-buy/task-reference/provide_performance_feedback.mdx - docs/protocols/a2a-guide.mdx - docs/protocols/envelope-examples.mdx - docs/protocols/getting-started.mdx - docs/protocols/protocol-comparison.mdx - docs/signals/tasks/activate_signal.mdx - docs/signals/tasks/get_signals.mdx Incorporates fixes from PR adcontextprotocol#231 by @EmmaLouise2018. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Add changeset for A2A artifactId documentation fixes --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incorporates PR #231 fixes for A2A protocol compliance. Adds missing
artifactIdfields to artifact examples and corrects request structure issues (field names, message wrapper, config location).Why this matters: A2A examples now correctly match the official specification, enabling developers to use copy-paste examples that actually work.
Test plan
All tests pass with no breaking changes.