fix(storyboards): inject caller into specialism check_governance fixtures - #2765
Merged
Conversation
…ures (adcp#2763) Matrix v9 wire-tap showed check_governance payloads omitting `caller` even after adcp#2740 patched protocols/governance/index.yaml. The specialisms are authored separately — they were missed. Mirrors the shape already landed in protocols/governance/index.yaml into three check_governance sample_requests across governance-spend-authority and governance-delivery-monitor. The denied.yaml variant already had caller. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
caller: "https://pinnacle-agency.example"into everycheck_governancesample_requestin the two affected specialism storyboards, matching the shape already landed inprotocols/governance/index.yamlvia adcp#2740.specialisms/governance-spend-authority/index.yaml, two inspecialisms/governance-delivery-monitor/index.yaml. (denied.yamlalready had it.)Context
Matrix v9 was failing
check_governanceruns. A logging proxy (4499 → 4500) captured the actual request payload and confirmedcallerwas missing on the wire. adcp#2740 had added it toprotocols/governance/index.yaml, but the specialisms are authored separately and were never updated — the runs that fail are hitting specialism fixtures.This is the narrower, verified half of the #2763 audit. Hypotheses for
build_creative(creative-template),sync_catalogs, andreport_usage(creative-ad-server) are not included here — those need their own wire-taps before committing to a specific shape.Test plan
npm run test:unit— 631 passednpm run typecheck— cleannpm run test:storyboard-scoping— passnpm run test:storyboard-context-entity— passnpm run test:storyboard-auth-shape— passcallerNote:
@adcp/clientconsumers won't see the fix until the compliance tarball is republished — the same republish-lag pattern as adcp#2335.🤖 Generated with Claude Code