chore(deps): bump @adcp/client 5.9.0 -> 5.9.1#2792
Merged
Conversation
Picks up adcp-client#752, which fixes default-invariants.ts's
context.no_secret_echo assertion — it treated options.auth as a string
and added the whole discriminated-union object to its secret set, so
String.includes(obj) coerced to '[object Object]' and matched nothing.
Silent no-op for every consumer using structured auth (bearer/basic/
oauth/oauth_client_credentials).
5.9.1 walks each auth variant and extracts leaf strings so the
assertion actually fires on leaked access_tokens, refresh_tokens,
client_secrets, basic-auth passwords, and base64'd Authorization: Basic
header values. Also adds registerAssertion(spec, { override: true }) —
not needed here since #2771 dropped our local stricter assertions in
favor of the SDK defaults, but the patch bump is worth picking up for
the bug fix alone.
Scoped: 5 lines in package-lock.json (just @adcp/client resolution +
integrity), no peer cascade, no code changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped patch bump to pick up adcp-client#752.
Why
5.9.0's default
context.no_secret_echoassertion in@adcp/client/testingsilently no-ops for every consumer passing structuredTestOptions.auth. The relevant code indefault-invariants.ts:Since #2771 adopted 5.9.0 and dropped our stricter local assertions in favor of the SDK defaults, we were implicitly depending on the default to work — but it doesn't, for any auth type other than a loose
options.auth_tokenstring. A compliance run that should have flagged a leaked access token, basic password, or client secret was passing cleanly.What 5.9.1 fixes
extractAuthSecretswalks every variant of theTestOptions.authunion and pulls leaf strings:token(bearer),password(basic) plus thebase64(user:pass)Authorization header blob,tokens.access_token/tokens.refresh_token(oauth and oauth_client_credentials),client.client_secret(oauth confidential),credentials.client_secretwith$ENV:VARreference resolution (oauth_client_credentials).SECRET_MIN_LENGTH = 16guards against short fixture values driving false positives.client_id(RFC 6749 §2.2 — public identifier) or basic-authusernamealone (not a secret; the base64 header blob catches real leaks of the credential).Also adds
registerAssertion(spec, { override: true })for consumers who want to swap a default for a stricter local version — not needed here post-#2771, but doesn't hurt to have in scope.Scope
package.json:"@adcp/client": "^5.9.0"→"^5.9.1"package-lock.json: 5 lines (just@adcp/client'sresolved+integrity)Verification
npm run typecheckcleannpm run test:server-unit— 1699 passed / 34 skipped / 0 failedcollection-lists-storyboard.test.ts(the one test whose fixture loading had flaked in earlier sessions) — passes cleanly on fresh install🤖 Generated with Claude Code