fix(storyboards): resolve 16-fixture actionable drift bundle (adcp#2763)

[bokelley]

Summary

Third cluster-bundle follow-up to the storyboard schema lint from #2768, #2781, #2788. Bundles all remaining actionable drift into one reviewable PR. Allowlist shrinks 29 → 13.

Lint change

isNegativeStep now treats expect_error: true as a canonical negative-step marker alongside the existing error_code / http_status_in heuristics. expect_error is the widely-used convention throughout the compliance suite (20+ sites) and resolves deliberate-error fixtures (reversed_dates, etc.) without needing per-fixture opt-ins.

Fixture changes (14 files, 16 allowlist entries resolved)

Shape completion — missing required fields:

• protocols/media-buy/state-machine.yaml#setup/create_buy — missing account
• protocols/sponsored-intelligence/index.yaml#session_lifecycle/si_terminate_session — missing reason
• specialisms/brand-rights/scenarios/governance_denied.yaml#rights_denied/get_rights_catalog — missing query/uses
• specialisms/audience-sync/index.yaml#audience_sync/create_audience — missing external_id on add[]
• specialisms/sales-catalog-driven/index.yaml#conversion_tracking/log_events — events used timestamp where schema wants event_time
• specialisms/sales-social/index.yaml#event_logging/log_event — missing event_source_id at root + event_time on event
• protocols/creative/index.yaml#build_and_preview/preview_display — missing request_type/creative_manifest/assets/format_id; populated the full single-request shape
• protocols/media-buy/creative-reception.yaml#preview/preview_synced — missing creative_manifest.assets
• protocols/media-buy/scenarios/creative_fate_after_cancellation.yaml#reuse_creative_on_new_buy/reassign_creative — creatives: [] required by schema minItems: 1 even for assignment-only calls; added minimal creatives[] padding
• specialisms/sales-non-guaranteed/index.yaml#adjust_bids/update_media_buy — packages used product_id but schema requires package_id; exposed first_package_id/second_package_id via context_outputs on the create step so update can reference them

Shape corrections:

• protocols/media-buy/scenarios/proposal_finalize.yaml#accept_proposal/create_media_buy — total_budget: 50000 → { amount: 50000, currency: "USD" }
• specialisms/sales-proposal-mode/index.yaml#accept_proposal/create_media_buy — same total_budget fix
• universal/deterministic-testing.yaml#deterministic_account/sync_accounts_for_state — flat brand/operator → accounts: [{...}] wrapper

additionalProperty removal:

• specialisms/sales-catalog-driven/index.yaml#account_setup/sync_accounts — removed brand.name (schema rejects)

Explicit negative-test opt-in:

• universal/error-compliance.yaml#error_responses/missing_fields — sample_request_skip_schema: true (step intentionally tests empty-brief path; accepts either response or error so no expect_error marker).

Ratchet

Allowlist: 29 → 13. Regenerated in shrink-only mode.

Remaining 13 entries — all blocked:

• 5 blocked on Schema docs: governance report/audit schemas reject account — author intuition collides with plan_id scoping #2776 (governance account additionalProperty)
• 4 blocked on Schema: refine[] field naming — schema wants generic id+action, storyboards author proposal_id/product_id #2775 (refine[] naming)
• 3 blocked on Schema: context field collision — SI schemas redefine core context as string with semantic meaning #2774 (SI context:string collision; one of these is in deterministic-testing)
• 1 is sales-social/sync_dpa_creative — creative-manifest assets anyOf cluster (separate PR)

Test plan

• npm run test:storyboard-sample-request-schema — passes (13 grandfathered, 0 new drift, 0 stale)
• All 6 other storyboard lints pass
• 8 lint unit tests pass
• npm run test:unit — 631 passed
• npm run typecheck — clean
• Each fixture cross-checked against its schema's required / additionalProperties / type constraints

🤖 Generated with Claude Code