fix(storyboards): use literal creative_id in creative_fate reassign (closes #2850)#2867
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2850. The
reassign_creativestep increative_fate_after_cancellation.yamlreferenced$context.creative_id, a key populated from the seller'ssync_creativesresponse atcreatives[0].creative_id. Sellers whose envelope doesn't surface that exact path resolved toundefined, the template engine stripped the creative entry, and the final request failed pre-flight zod with "creatives: expected array, received undefined" — before reaching the agent.Uses the buyer-set literal
acme_reuse_banner_001(from phase 1'ssync_creative_with_assignment) instead. Buyer-authoritative; robust against envelope variance.Test plan
reassign_creativestep without SDK pre-flight rejection (verified locally against the adcp-1 training agent).