fix(deps): bump @adcp/client to 5.11.0 for get_rights builder fix (closes #2846)#2883
Merged
Conversation
…oses #2846) Upstream PR adcontextprotocol/adcp-client#792 restored sample_request handling in the storyboard runner's get_rights builder. Before, the builder hardcoded query/uses and derived brand_id from the caller's domain, silently discarding every field the storyboard declared. Rights-holder rosters rejected the caller-domain brand_id as unknown, so rights[0] was undefined, \$context.rights_id didn't resolve, and acquire_rights failed with rights_not_found before the training agent's existing GOVERNANCE_DENIED check in brand-handlers.ts:978 could run. With 5.11.0 the brand_rights/governance_denied scenario passes 5/5 against the training agent. CI floors rebaselined: - legacy: 36→43 clean storyboards, 295→336 passing steps - framework: 21→25 clean storyboards, 241→244 passing steps Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolved conflict in .github/workflows/training-agent-storyboards.yml by combining main's floor bumps (44→ and 37→ from cross-agent format and framework session-context fixes) with #2846's @adcp/client 5.11.0 bump. Re-ran storyboards against the merged state: - legacy: 46 clean / 338 passing - framework: 42 clean / 339 passing Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@adcp/clientfrom^5.10.0to^5.11.0to pick up adcontextprotocol/adcp-client#792, which restoredsample_requesthandling in the storyboard runner'sget_rightsbuilder.Why
#2846 reported
brand_rights/governance_deniedfailing with the wrong error code. Root cause was in the SDK, not the training agent: theget_rightsbuilder hardcodedquery/usesand derivedbrand_idfrom the caller's domain, silently discarding every field the storyboard declared. Rights-holder rosters rejected the caller-domainbrand_idas unknown —rights[0]was undefined,$context.rights_idnever resolved, and downstreamacquire_rightsfailed withrights_not_foundbefore the training agent's existingGOVERNANCE_DENIEDcheck inbrand-handlers.ts:978could run.The training-agent code was already correct. The fix is the SDK bump.
Test plan
brand_rights/governance_deniedstoryboard: 4P/1F → 5P/0F🤖 Generated with Claude Code