Skip to content

fix(schema): correct title annotation in rate-limited error-details schema #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
Apr 25, 2026
Merged

fix(schema): correct title annotation in rate-limited error-details schema #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d0467
fix(schema): correct title annotation in rate-limited error-details s…
claude Apr 25, 2026
1b45132
revert: drop dist/schemas/ hand-edits per #3149 review
Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/fix-rate-limited-schema-title.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Fix `title` in `error-details/rate-limited.json` from `"RATE_LIMITED Details"` to `"Rate Limited Details"`. The JSON Schema `title` annotation is non-normative; no validation or wire-format change. This corrects the generated TypeScript type name from `RATE_LIMITEDDetails` to `RateLimitedDetails` in downstream codegen consumers (see adcp-client#942 for the SDK alias layer).
2 changes: 1 addition & 1 deletion static/schemas/source/error-details/rate-limited.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$id": "/schemas/error-details/rate-limited.json",
"title": "RATE_LIMITED Details",
"title": "Rate Limited Details",
"description": "Recommended details shape for RATE_LIMITED errors. Provides rate limit window information so agents can plan request pacing.",
"type": "object",
"properties": {
Expand Down
Loading