feat(media-buy): supports_proposals capability flag — closes #3844#3865
Merged
Conversation
Adds wire-level capability gate so proposal_finalize cleanly folds into sales-guaranteed.requires_scenarios without forcing direct-buy guaranteed sellers (auction PG, retail SKU) to grade against proposal flows. - get-adcp-capabilities-response.json: new media_buy.supports_proposals boolean. Declared as a commitment (seller will return proposals[] for buying_mode='brief' and honor action='finalize' to commit a draft), not a feature flag — sellers are graded against the declaration. - proposal_finalize.yaml: requires_capability gate on media_buy.supports_proposals=true. Sellers that declare false skip as capability_unsupported; sellers that declare true (or omit per runner's absence semantics) are graded against it. - sales-guaranteed: proposal_finalize joins requires_scenarios; narrative reflects the capability-gated grading. - sales-proposal-mode + specialism.json: deprecation notes point sellers at the migration path (drop the specialism, declare sales-guaranteed + media_buy.supports_proposals: true). Storyboard retained through 3.x. - training-agent: declares supports_proposals: true (it implements the full proposal lifecycle). Local: media_buy_seller/proposal_finalize ✓ 1P / 4S / 0N/A on /sales tenant. Refs: #3823, #3840. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media_buy.supports_proposals: booleaninget-adcp-capabilities-response.json. Declared as a commitment (seller will return at least one entry inproposals[]forbuying_mode='brief'and honoraction='finalize'), not a feature flag.proposal_finalize.yamldeclaresrequires_capability: { path: media_buy.supports_proposals, equals: true }. Sellers that explicitly declarefalseskip ascapability_unsupported; sellers that declaretrue(or omit the field per the runner's absence semantics) are graded against it.sales-guaranteed/index.yaml: foldsproposal_finalizeintorequires_scenarios(now safe — capability-gated). Narrative trimmed.sales-proposal-mode/index.yaml+enums/specialism.json: deprecation notes point sellers at the migration path — drop the specialism, declaresales-guaranteedplusmedia_buy.supports_proposals: true.supports_proposals: true(it implements the full proposal lifecycle).Unblocks the clean fold-in that #3840 left tracked at #3844.
Test plan
npm run build:schemas— cleannpm run build:compliance— clean (lints, no contradictions, 22/6/19)media_buy_seller/proposal_finalize ✓ 1P / 4S / 0N/Aon/salestenantRefs: #3823, #3840, #3844.
🤖 Generated with Claude Code