fix(schemas): three measurement audit cleanups (§3.8, §3.10, #3863 prose)#3886
Merged
Conversation
…ose) §3.8 attribution-window dedup: - optimization-goal.json: inline attribution_window with conflicting constraints (post_click required, no model field) collapses to $ref attribution-window.json. One canonical shape. - attribution-window.json: model becomes optional (was required). Absence means seller's default applies. Sellers SHOULD populate when committing to a specific methodology. Buyer payloads that previously failed validation (no model) now pass; previously-valid payloads remain valid. §3.10 dooh_metrics.calculation_notes description tightening: - Was a one-liner that read like a primary methodology surface. - Tightened to clarify row-specific supplementary context only — canonical methodology lives on the measurement vendor's get_adcp_capabilities.measurement.metrics[] block where it's discoverable once and inherited. #3863 forecastable-metric description drift fix: - Previous description claimed grps/reach/frequency were forecast-only deltas. Wrong — those are in available-metric.json too. Actual forecast-only deltas are audience_size and measured_impressions only. - Closes the prose-cross-reference half of #3863. Build-script overlap enforcement deferred. All changes additive or constraint-relaxing. No breaking changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small cleanups from the measurement schema audit. All additive or constraint-relaxing — no breaking changes.
§3.8 —
attribution-windowdedupoptimization-goal.jsonpreviously inlined a partialattribution_window(post_click + post_view, no model, post_click required) — divergent from the canonicalcore/attribution-window.json(post_click + post_view + model, model required).Fix:
optimization-goal.jsonattribution_window→$ref attribution-window.jsonattribution-window.jsonmodelbecomes optional (was required); absence means seller's default. Existing buyer payloads that omitted model now validate; previously-valid payloads remain valid.§3.10 —
dooh_metrics.calculation_notesdescription tighteningWas a one-liner that read like a primary methodology surface. Tightened to clarify row-specific supplementary context only — canonical methodology lives on the measurement vendor's
get_adcp_capabilities.measurement.metrics[]block.#3863 —
forecastable-metric.jsondescription drift fixPrevious description claimed
grps,reach,frequencywere forecast-only. Wrong — those are inavailable-metric.jsontoo. Actual forecast-only deltas areaudience_sizeandmeasured_impressions. Description corrected.Closes the prose-cross-reference half of #3863. Build-script overlap enforcement deferred to a follow-up.
Files
static/schemas/source/core/attribution-window.json— model becomes optionalstatic/schemas/source/core/optimization-goal.json— inline def → $refstatic/schemas/source/core/delivery-metrics.json— calculation_notes description tightenedstatic/schemas/source/enums/forecastable-metric.json— description corrected.changeset/measurement-audit-cleanups.md— minorTest plan
Related
🤖 Generated with Claude Code