Skip to content

fix(compliance): seed governance_agent_url default via storyboard-root context: block#3916

Merged
bokelley merged 1 commit into
mainfrom
claude/issue-3913-seed-governance-agent-url
May 3, 2026
Merged

fix(compliance): seed governance_agent_url default via storyboard-root context: block#3916
bokelley merged 1 commit into
mainfrom
claude/issue-3913-seed-governance-agent-url

Conversation

@bokelley

@bokelley bokelley commented May 3, 2026

Copy link
Copy Markdown
Contributor

Closes #3913

Six governance storyboards (sync_governance steps in media-buy, brand-rights, and signal-marketplace scenarios) referenced $context.governance_agent_url in their sample_request payloads but never seeded it. Runners emitted SKIP: unresolved context variables from prior steps: governance_agent_url, causing the downstream steps to run without a registered governance binding and the storyboard to produce false negatives even against spec-correct agents. This PR adds a storyboard-root context: block to each affected YAML seeding the training-agent URL as the default, and formally adds the context: field to the top-level spec section in storyboard-schema.yaml (it was only described in the accumulator prose, not the field list). Narratives updated to remove the reference to a non-existent --governance-agent-url CLI flag.

Non-breaking justification: adds an optional context: block (new field, no wire change); all existing runners that do not implement accumulator source 2 simply ignore it — the SKIP behaviour is unchanged for those runners, which is the same as today. Runners that do implement source 2 (per the 3.0.5 spec) will now resolve the variable and exercise the step as intended.

Note — 3.0.x cherry-pick recommended: The dist/compliance/3.0.13.0.5 versioned snapshots are frozen and still carry the unresolved $context.governance_agent_url. Adopters pinned to a 3.0.x dist (including the bokelley/hello-adapters-gov-rights adapter that surfaced this issue at 3.0.5) need this cherry-picked to 3.0.x and a new patch release cut to see the fix in a versioned snapshot.

Sibling-repo-fix-needed: adcp-clientadcp storyboard run lacks a --context KEY=VALUE flag (single-step has --context JSON but full run mode does not). Adopters who need to override governance_agent_url to point at their own governance agent currently cannot do so without editing the storyboard YAML. The context: block default unblocks the training-agent path; the CLI flag is needed for the custom-agent path.

Pre-PR review:

  • ad-tech-protocol-expert: approved — field placement correct, scalar-only constraint accurate, training-agent URL matches existing narratives; no blockers
  • code-reviewer: approved — logic sound, all 6 storyboards patched, schema doc consistent, changeset correctly --empty; flagged 3.0.x frozen-dist gap (noted above)

Triage-managed PR. This bot does not currently iterate on
review comments or PR conversation threads (only on the source
issue). To unblock:

  • Push fixup commits directly: gh pr checkout <num>
    fix → push.
  • Or re-trigger: comment /triage execute on the source
    issue.

See #3121
for context.

Session: https://claude.ai/code/session_019r8L5mpimhpvn5NDBUbzjt


Generated by Claude Code

…t context: block

Six governance storyboards (media-buy, brand-rights, signal-marketplace)
referenced $context.governance_agent_url in sync_governance sample_request
payloads without ever seeding it, causing runners to emit:
  SKIP: unresolved context variables from prior steps: governance_agent_url

Fix: add a top-level context: block to each of the 6 affected storyboards,
seeding the training agent URL as the default. The storyboard-schema spec
already documented this block as accumulator source 2 but had not listed it
in the top-level field definition — also corrected here.

Also updates the narrative override instruction from the non-existent
--governance-agent-url flag to the correct context: seeding mechanism.

Closes #3913

Sibling-repo-fix-needed: adcp-client — add --context KEY=VALUE flag to
`adcp storyboard run` so adopters can override governance_agent_url at
invocation time without modifying the storyboard YAML.

https://claude.ai/code/session_019r8L5mpimhpvn5NDBUbzjt
@bokelley bokelley added the claude-triaged Issue has been triaged by the Claude Code triage routine. Remove to re-triage. label May 3, 2026
@bokelley bokelley marked this pull request as ready for review May 3, 2026 23:31
@bokelley bokelley merged commit 88a40b1 into main May 3, 2026
19 checks passed
@bokelley bokelley deleted the claude/issue-3913-seed-governance-agent-url branch May 3, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-triaged Issue has been triaged by the Claude Code triage routine. Remove to re-triage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storyboard runner: no way to seed $context.governance_agent_url for full storyboard run mode

2 participants