fix(compliance): seed governance_agent_url default via storyboard-root context: block#3916
Merged
Merged
Conversation
…t context: block Six governance storyboards (media-buy, brand-rights, signal-marketplace) referenced $context.governance_agent_url in sync_governance sample_request payloads without ever seeding it, causing runners to emit: SKIP: unresolved context variables from prior steps: governance_agent_url Fix: add a top-level context: block to each of the 6 affected storyboards, seeding the training agent URL as the default. The storyboard-schema spec already documented this block as accumulator source 2 but had not listed it in the top-level field definition — also corrected here. Also updates the narrative override instruction from the non-existent --governance-agent-url flag to the correct context: seeding mechanism. Closes #3913 Sibling-repo-fix-needed: adcp-client — add --context KEY=VALUE flag to `adcp storyboard run` so adopters can override governance_agent_url at invocation time without modifying the storyboard YAML. https://claude.ai/code/session_019r8L5mpimhpvn5NDBUbzjt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3913
Six governance storyboards (
sync_governancesteps in media-buy, brand-rights, and signal-marketplace scenarios) referenced$context.governance_agent_urlin theirsample_requestpayloads but never seeded it. Runners emittedSKIP: unresolved context variables from prior steps: governance_agent_url, causing the downstream steps to run without a registered governance binding and the storyboard to produce false negatives even against spec-correct agents. This PR adds a storyboard-rootcontext:block to each affected YAML seeding the training-agent URL as the default, and formally adds thecontext:field to the top-level spec section instoryboard-schema.yaml(it was only described in the accumulator prose, not the field list). Narratives updated to remove the reference to a non-existent--governance-agent-urlCLI flag.Non-breaking justification: adds an optional
context:block (new field, no wire change); all existing runners that do not implement accumulator source 2 simply ignore it — the SKIP behaviour is unchanged for those runners, which is the same as today. Runners that do implement source 2 (per the 3.0.5 spec) will now resolve the variable and exercise the step as intended.Note — 3.0.x cherry-pick recommended: The
dist/compliance/3.0.1–3.0.5versioned snapshots are frozen and still carry the unresolved$context.governance_agent_url. Adopters pinned to a 3.0.x dist (including thebokelley/hello-adapters-gov-rightsadapter that surfaced this issue at 3.0.5) need this cherry-picked to3.0.xand a new patch release cut to see the fix in a versioned snapshot.Sibling-repo-fix-needed: adcp-client —
adcp storyboard runlacks a--context KEY=VALUEflag (single-step has--context JSONbut full run mode does not). Adopters who need to overridegovernance_agent_urlto point at their own governance agent currently cannot do so without editing the storyboard YAML. Thecontext:block default unblocks the training-agent path; the CLI flag is needed for the custom-agent path.Pre-PR review:
--empty; flagged 3.0.x frozen-dist gap (noted above)Session: https://claude.ai/code/session_019r8L5mpimhpvn5NDBUbzjt
Generated by Claude Code