feat(spec): add sponsored-intelligence to AdCPSpecialism enum#3963
Closed
bokelley wants to merge 2 commits into
Closed
feat(spec): add sponsored-intelligence to AdCPSpecialism enum#3963bokelley wants to merge 2 commits into
bokelley wants to merge 2 commits into
Conversation
Adds `sponsored-intelligence` as a preview specialism alongside its compliance storyboard. The four SI lifecycle tasks already exist in the spec; this gives them a specialism ID so SDK v6 can define a SponsoredIntelligencePlatform interface using the same RequiredPlatformsFor<S> dispatch as all other specialisms. Ships as status: preview because SI schemas carry x-status: experimental. Storyboard produces no stable pass/fail verdict until schemas graduate. Touches three locations atomically to satisfy the adcp-taxonomy.test.ts parity check: specialism.json enum + ADCP_SPECIALISMS array + storyboard directory. Refs #3961 https://claude.ai/code/session_015vM78ky3xSqQj4FMqEZmDe
… specialism Updates the specialism-status test block to reflect that sponsored-intelligence is now the first specialism with status: preview. Adds an explicit assertion so the preview dispatch path is covered rather than left as a comment noting it is "for future use". https://claude.ai/code/session_015vM78ky3xSqQj4FMqEZmDe
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3961
Adds
sponsored-intelligenceas a preview specialism inAdCPSpecialism, closing the asymmetry between the SI protocol declaration (supported_protocols: ['sponsored_intelligence']) and the specialism registry. The four SI lifecycle tasks (si_get_offering,si_initiate_session,si_send_message,si_terminate_session) have been in the spec since 3.0 — this gives them a specialism ID so SDK v6 can defineSponsoredIntelligencePlatformusing the sameRequiredPlatformsFor<S>dispatch pattern as all other specialisms.Non-breaking justification: Adds a new enum value appended to the end of
AdCPSpecialism; existing agents are unaffected; specialism claims are opt-in; the protocol declaration (sponsored_intelligenceinsupported_protocols) continues to coexist unchanged.Three-location atomic update required to satisfy the
adcp-taxonomy.test.tsparity check:static/schemas/source/enums/specialism.json— new enum value +enumDescriptionsentryserver/src/services/adcp-taxonomy.ts— newAdcpSpecialismunion member +ADCP_SPECIALISMSarray entrystatic/compliance/source/specialisms/sponsored-intelligence/index.yaml— new preview storyboard withrequires_scenarios: [si_baseline]Ships as
status: previewbecause the underlying SI schemas carryx-status: experimental. The compliance runner produces no stable pass/fail verdict until schemas graduate. Consistent with the preview-specialism pattern established for other experimental surfaces. Fits the #2511 (re-add preview specialisms) wave in 3.1.The storyboard has a single
capability_discoveryphase verifying bothsponsored_intelligenceinsupported_protocolsandsponsored-intelligenceinspecialisms. The full SI session lifecycle (offering discovery → session lifecycle) is pulled in viarequires_scenarios: [si_baseline]. This is intentional for a preview storyboard — the lifecycle is already covered by the protocol-level baseline; the specialism adds the coexistence invariant check.Nit (not addressed here): The protocol-level SI storyboard at
static/compliance/source/protocols/sponsored-intelligence/index.yamluses real company names inagent.exampleswhich violates the playbook's no-real-brands rule. Separate cleanup warranted — not in scope for this enum-addition PR.Pre-PR review:
requires_scenariosmust reference storyboardid: si_baseline, not filesystem pathprotocols/sponsored-intelligence)adcp-taxonomy.test.ts); remaining findings are nits or already-resolved (therequires_scenariospath fix was applied before their review ran)Session: https://claude.ai/code/session_015vM78ky3xSqQj4FMqEZmDe