ci(storyboards): skip two SDK-blocked steps on /sales, ratchet floor#4069
Merged
Conversation
create_media_buy_submitted step blocked on adcp-client#1554 (handoffToTask needs caller-supplied task_id overload). get_delivery_with_vendor_metrics blocked on adcp-client#1552 (runner drops vendor_metric_values from comply params). Both added to KNOWN_FAILING_STEPS with linked issues. Sales floor 65→67 clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two storyboard steps on
/salesfail on framework-routed sellers due to SDK gaps. Adding both toKNOWN_FAILING_STEPSwith linked source-of-truth issues so the runner reports them as skipped rather than failed; ratcheting the /sales floor to capture the lift.Step 1:
media_buy_seller/create_media_buy_async/create_media_buy_submitted— adcp-client#1554The v5
createMediaBuyhandler returns a hand-rolled{ status: 'submitted', task_id }envelope when theforce_create_media_buy_armdirective is set. The v6 framework's projector (from-platform.js:1438) rejects that shape — the only path into the submitted arm isctx.handoffToTask(fn), which assigns a framework-issued task_id. The test-controller directive requires the seller to return the caller-supplied task_id (so the runner can assert againstforced.task_id), whichhandoffToTaskcannot satisfy until the SDK exposes a{ task_id }overload.Step 2:
media_buy_seller/vendor_metric_accountability/get_delivery_with_vendor_metrics— adcp-client#1552The SDK runner drops extension params (e.g.
vendor_metric_values) fromcomply_test_controllerrequests before they hit the wire. The agent'ssimulate_deliveryhandler never sees the array, so the downstream delivery assertion finds nothing onby_package[].vendor_metric_values. Pure runner gap — the spec declaresparamsas passthrough.Floor lift on /sales:
Both skipped storyboards (
create_media_buy_async,vendor_metric_accountability) now grade clean — only one step is skipped per storyboard; the rest pass.Other tenants flat — these storyboards are sales-only.
Test plan
🤖 Generated with Claude Code