Skip to content

fix(compliance): chain proposal_id through proposal_finalize storyboard (3.0.x) #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
May 4, 2026
Merged

fix(compliance): chain proposal_id through proposal_finalize storyboard (3.0.x) #4092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/proposal-finalize-context-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---

**conformance**: chain `proposal_id` through `media_buy_seller/proposal_finalize` storyboard.

The `brief_with_proposals` step now captures `proposals[0].proposal_id` via `context_outputs`, and the downstream `refine_proposal` / `finalize_proposal` / `accept_proposal` steps reference it as `$context.proposal_id` instead of the hardcoded placeholder `balanced_reach_q2`. Sellers that mint runtime `proposal_id` values (uuids, db rowids) can now pass the full lifecycle — previously the literal placeholder reached the wire and 404'd against any stateful upstream. Closes #4086.
10 changes: 7 additions & 3 deletions static/compliance/source/protocols/media-buy/scenarios/proposal_finalize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ phases:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"

context_outputs:
- path: "proposals[0].proposal_id"
key: "proposal_id"

validations:
- check: response_schema
description: "Response matches get-products-response.json schema"
Expand Down Expand Up @@ -137,7 +141,7 @@ phases:
buying_mode: "refine"
refine:
- scope: "proposal"
proposal_id: "balanced_reach_q2"
proposal_id: "$context.proposal_id"
ask: "Shift 60% of budget to CTV. Drop the display product and redistribute that budget to video."
- scope: "request"
ask: "All products must support frequency capping at 3 per day."
Expand Down Expand Up @@ -184,7 +188,7 @@ phases:
buying_mode: "refine"
refine:
- scope: "proposal"
proposal_id: "balanced_reach_q2"
proposal_id: "$context.proposal_id"
action: "finalize"
account:
brand:
Expand Down Expand Up @@ -230,7 +234,7 @@ phases:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
sandbox: true
proposal_id: "balanced_reach_q2"
proposal_id: "$context.proposal_id"
total_budget:
amount: 50000
currency: "USD"
Expand Down
Loading