Skip to content

chore(deps): bump @adcp/sdk to ^6.19.0; drop vector-028 skipVectors workaround #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
May 11, 2026
Merged

chore(deps): bump @adcp/sdk to ^6.19.0; drop vector-028 skipVectors workaround #4359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .changeset/sdk-6.19-drop-vector-028-skip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
"adcontextprotocol": patch
---

chore(deps): bump `@adcp/sdk` to ^6.19.0; drop vector-028 skipVectors workaround

`@adcp/sdk@6.18.0` added the adversarial builder for conformance vector `028-unsigned-protocol-method-required` ([adcp-client#1644](https://github.com/adcontextprotocol/adcp-client/pull/1644)), which the test-agent's storyboard matrix had been skipping via `skipVectors` since vector 028 landed in [adcp#4335](https://github.com/adcontextprotocol/adcp/pull/4335). `6.19.0` ships the proposal-mode enricher fix ([adcp-client#1649](https://github.com/adcontextprotocol/adcp-client/pull/1649)) that PR #1603's over-application surfaced — required for the storyboard matrix to stay green at SDK 6.18+.

Vector 028 grades the `protocol_methods_required_for` namespace introduced in [adcp#4326](https://github.com/adcontextprotocol/adcp/pull/4326) — an unsigned `tasks/cancel` JSON-RPC POST against a verifier declaring `protocol_methods_required_for: ["tasks/cancel"]` MUST 401 with `request_signature_required`. The test-agent's strict route already enforces this; this PR closes the loop by removing the local skip so the runner actually exercises the vector.

Matrix lift (+1 step per tenant from vector 028 grading):

| Tenant | Before | After |
|-------------------|--------|-------|
| /signals | 58 | 59 |
| /sales | 258 | 260 |
| /governance | 102 | 103 |
| /creative | 118 | 119 |
| /creative-builder | 100 | 101 |
| /brand | 45 | 46 |
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"dev:docs": "node scripts/dev-docs.mjs"
},
"dependencies": {
"@adcp/sdk": "^6.13.0",
"@adcp/sdk": "^6.19.0",
"@anthropic-ai/sdk": "^0.91.1",
"@asteasolutions/zod-to-openapi": "^8.5.0",
"@contentauth/c2pa-node": "^0.5.4",
Expand Down
5 changes: 0 additions & 5 deletions server/tests/manual/run-storyboards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,6 @@ async function main() {
'007-missing-content-digest',
'018-digest-covered-when-forbidden',
'025-jwk-alg-crv-mismatch',
// Vector 028 grades `protocol_methods_required_for` (introduced
// in adcp#4326). The SDK runner does not yet ship an adversarial
// builder for it — un-skip once `@adcp/sdk` adds the builder.
// Tracked under the runner-implementation umbrella adcp#2331.
'028-unsigned-protocol-method-required',
],
skipRateAbuse: true,
},
Expand Down
Loading