fix(admin): upgrade adagents.json builder and manager from v2 to v3 schema

[bokelley]

Refs #4411

Summary

• 7 hardcoded v2 schema URLs replaced with v3 across adagents-builder.html (4 occurrences) and AdAgentsManager (suggestion string, createAdAgentsJson, validateProposed). Unit test assertions updated to match.
• Contact section added (collapsible, file-level): name, email, domain, privacy_policy_url, seller_id, tag_id. Fully round-trips on import.
• Property features tab added (🏆 Features): inline CSP-safe add/edit form for property_features[] — third-party certification agents (Scope3, TAG, OneTrust) with feature IDs and optional publisher ID. Cards rendered via createElement/textContent (no innerHTML with user data).
• Per-agent v3 constraint fields in agent modal: exclusive (checkbox), countries (comma-separated alpha-2 with validation feedback for rejected codes), effective_from/effective_until (datetime-local → ISO 8601), encryption_keys (structured X25519 repeater: kid ≤8 chars + base64url x 43–44 chars, strict unpadded regex per RFC 4648 §5, client-side validation), signing_keys (flexible JWK JSON textarea per key).
• Import paths (importFile, domain-validation flow) fully restore v3 state (contact, property_features, per-agent v3 fields).

Not in scope (deferred by expert consensus)

collections[] and placements[] are the remaining major v3 additions. All three experts (internal-tools-strategist, adtech-product-expert, ad-tech-protocol-expert) agreed these are the largest pieces and should be a follow-up PR. v2 sunset is 2026-08-01, so the TMPX-critical fields (encryption_keys) land now.

Non-breaking

No API contract changes. The builder is a client-side admin tool; exported JSON now validates against the v3 schema. Publishers running v2-generated files are unaffected — the change updates what the builder outputs, not what the server validates against.

Pre-PR expert review sign-offs

Three experts consulted before implementation, two after (on the diff):

Code-reviewer:

• ✅ XSS in renderPropertyFeatures — fixed (switched to createElement/textContent)
• ✅ Base64url regex accepted padding (=?) — fixed (strict ^[A-Za-z0-9_-]+$ per RFC 4648)
• ✅ Dead variable in updateEncKey — removed
• ✅ Changeset present
• 📋 Hardcoded #666 colors in new UI (pre-existing pattern in file) — NIT, not fixed to keep diff focused
• 📋 populateContactForm some(v => v) check — NIT, string fields only, low risk

Internal-tools-strategist:

• ✅ prompt() chain for property features blocked by enterprise CSP — replaced with inline form
• ✅ Countries field silently drops invalid codes — now alerts and returns with rejected token list
• 📋 Contact section defaults collapsed — NIT for internal staff audience

---

Triage-managed PR — opened by the AdCP triage routine for issue #4411. A human reviewer must approve before merge. Do not merge without review.

https://claude.ai/code/session_018ETvNpo7B7a5UjLfiCzaCb

---

Generated by Claude Code

[bokelley]

Post-expert-review fix-up landed in a8d5438:

• XSS in renderEncryptionKeysList / renderSigningKeysList — code-reviewer + security-reviewer both flagged independently. Both renderers interpolated user-controlled key fields (kid, x, JWK members) into innerHTML template strings; exploitable via importFile → editAgent if a publisher imported a malicious adagents.json. Switched both to createElement + textContent/.value, matching the prior fix applied to renderPropertyFeatures.
• server/src/publishers.ts:137 — missed v2 emit path in the original PR (a fix: suggestion string still pointed at v2). Updated to v3.

E2E coverage (Playwright against the docker-served build, all 4 pass):

1. Golden path — domain → contact → agent with exclusive/countries (normalized US,ca,GB → [US,CA,GB])/effective window/X25519 encryption_keys → JSON preview asserted to have $schema: …/v3/adagents.json and all new fields.
2. Invalid country codes (USA, X1) → alert + save blocked.
3. X25519 x with trailing = → alert + save blocked (regression test for the prior =? regex fix).
4. XSS regression — state.agents seeded with payloads '"><img onerror=alert(...)>' in kid/x and '</textarea><script>…</script>' in JWK members; opening the agent for edit no longer fires the dialog, payloads land verbatim as text in inputs/textarea, no injected <img>/<script> nodes.

Admin-merging: the failing Server integration tests check is identically failing on main (commit add005658) — makeWorkOSMock throwing in membership-webhook.test.ts:413 and listCustomersWithOrgIds missing from the stripe-client vitest mock in two registry tests. None of those paths touch anything this PR changes.