Skip to content

fix(cert): A2B success_criteria as {id,text} objects (unbreak main)#4535

Merged
bokelley merged 1 commit into
mainfrom
bokelley/a2b-criteria-objects
May 14, 2026
Merged

fix(cert): A2B success_criteria as {id,text} objects (unbreak main)#4535
bokelley merged 1 commit into
mainfrom
bokelley/a2b-criteria-objects

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

Verification

  • Applied 478 + 479 against a fresh local Postgres.
  • Verified 12 criteria across a2b_ex1..a2b_ex4 now render as {id, text} with ids a2b_ex1_c1, a2b_ex1_c2, …, a2b_ex4_c3.
  • vitest run server/tests/integration/demonstrations-fairness.test.ts13/13 pass locally (was 12/13 with the same DB pre-479).

Test plan

  • CI: Server integration tests green
  • Spot-check A2B module in /learning still renders exercises correctly post-migration

🤖 Generated with Claude Code

Migration 478 shipped success_criteria as plain strings; SuccessCriterion is
{ id, text } and demonstrations-fairness asserts every criterion has an id, so
main has been red on Server integration tests since PR #3398. Migration 479
converts each string criterion to { id: <ex>_c<n>, text: <string> }. Idempotent
— pre-existing object criteria pass through unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley bokelley enabled auto-merge (squash) May 14, 2026 12:18
@bokelley bokelley merged commit 600e3fd into main May 14, 2026
14 checks passed
@bokelley bokelley deleted the bokelley/a2b-criteria-objects branch May 14, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant