spec(adagents): clarify revoked_publisher_domains[] applies to inline_properties branch#4871
Merged
bokelley merged 2 commits intoMay 22, 2026
Merged
Conversation
…_properties branch Adds authorized_agents[].properties[].publisher_domain (inline_properties authorization type) to the explicit enumeration in both the JSON schema description and the managed-networks.mdx validator-behavior bullet. The prior text named two of three authorization-type branches, leaving inline_properties ambiguous and blocking SDK implementations. Closes #4869.
…oked-domains-inline-properties # Conflicts: # static/schemas/source/adagents.json
Contributor
There was a problem hiding this comment.
LGTM. Completes the two-of-three enumeration introduced in #4536; the underlying regardless of where else it appears normative was already load-bearing, this just makes it machine-scannable for SDK code-gen.
Things I checked
inline_propertiesJSON path verified by walking the discriminated union:adagents.json:401-414(companionproperties[]→core/property.json:59-62definespublisher_domain).authorized_agents[].properties[].publisher_domainis the right shape.- Schema description (
static/schemas/source/adagents.json:95) and docs bullet (docs/governance/property/managed-networks.mdx:638) are textually consistent — same three branches, same ordering, same(inline_properties authorization type)parenthetical, same Oxford comma. patchchangeset is the right semver: description-string-only, no field renames, no enum changes, no required/optional flips, no new fields. No wire-shape change.oneOfdiscriminator structures atadagents.json:224, 401, 487are untouched — audit walker / baseline unaffected.- Collateral check: other
revoked_publisher_domainsmentions (docs/governance/property/adagents.mdx:178, 533,docs/aao/directory-api.mdx:185,static/schemas/source/aao/agent-publishers.json:89) use the catch-allregardless of where else it appearsphrasing or don't enumerate branches — no drift created. - Good incidental fix: adding the
authorized_agents[].prefix to thepublisher_propertiespath in the docs bullet — every branch in the enumeration now carries an explicit root anchor.
Safe to merge.
Contributor
|
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final This is an automated message from the Argus AI review workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4869
The
revoked_publisher_domains[]schema description and themanaged-networks.mdxvalidator-behavior bullet previously named two of three authorization-type branches —publisher_propertiesselectors and top-levelproperties[].publisher_domain— but were silent on theinline_propertiesbranch. This left SDK implementers unable to determine whetherauthorized_agents[].properties[].publisher_domainentries should be filtered, blocking adcp-client-python#758.This PR adds
authorized_agents[].properties[].publisher_domain(inline_propertiesauthorization type) to the explicit enumeration in both places. The underlying normative intent — "regardless of where else it appears" — was already present; this change makes the enumeration complete and machine-scannable for SDK code-generation paths.Non-breaking justification: adds text to a schema
descriptionfield and a docs bullet; no wire-format change, no new required fields, no enum changes. Existing implementations unaffected.Pre-PR review:
authorized_agents[].properties[].publisher_domainconfirmed correct through discriminated-union schema traversal; changeset bumppatchconfirmed correct; no blockersauthorized_agents[].prefix to thepublisher_propertiespath in the MDX bullet to maintain path-convention consistency across all three enumerated branches)Session: https://claude.ai/code/session_019pW1avMCfo5Sn6yanP5eCc
Generated by Claude Code