Skip to content

spec(adagents): clarify revoked_publisher_domains[] applies to inline_properties branch#4871

Merged
bokelley merged 2 commits into
mainfrom
claude/issue-4869-revoked-domains-inline-properties
May 22, 2026
Merged

spec(adagents): clarify revoked_publisher_domains[] applies to inline_properties branch#4871
bokelley merged 2 commits into
mainfrom
claude/issue-4869-revoked-domains-inline-properties

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Closes #4869

The revoked_publisher_domains[] schema description and the managed-networks.mdx validator-behavior bullet previously named two of three authorization-type branches — publisher_properties selectors and top-level properties[].publisher_domain — but were silent on the inline_properties branch. This left SDK implementers unable to determine whether authorized_agents[].properties[].publisher_domain entries should be filtered, blocking adcp-client-python#758.

This PR adds authorized_agents[].properties[].publisher_domain (inline_properties authorization type) to the explicit enumeration in both places. The underlying normative intent — "regardless of where else it appears" — was already present; this change makes the enumeration complete and machine-scannable for SDK code-generation paths.

Non-breaking justification: adds text to a schema description field and a docs bullet; no wire-format change, no new required fields, no enum changes. Existing implementations unaffected.

Pre-PR review:

  • code-reviewer: approved — JSON path authorized_agents[].properties[].publisher_domain confirmed correct through discriminated-union schema traversal; changeset bump patch confirmed correct; no blockers
  • docs-expert: approved after one fix (added authorized_agents[]. prefix to the publisher_properties path in the MDX bullet to maintain path-convention consistency across all three enumerated branches)

Triage-managed PR. This bot does not currently iterate on
review comments or PR conversation threads (only on the source
issue). To unblock:

  • Push fixup commits directly: gh pr checkout <num>
    fix → push.
  • Or re-trigger: comment /triage execute on the source
    issue.

See #3121
for context.

Session: https://claude.ai/code/session_019pW1avMCfo5Sn6yanP5eCc


Generated by Claude Code

…_properties branch

Adds authorized_agents[].properties[].publisher_domain (inline_properties
authorization type) to the explicit enumeration in both the JSON schema
description and the managed-networks.mdx validator-behavior bullet.

The prior text named two of three authorization-type branches, leaving
inline_properties ambiguous and blocking SDK implementations.

Closes #4869.
@bokelley bokelley added the claude-triaged Issue has been triaged by the Claude Code triage routine. Remove to re-triage. label May 20, 2026
…oked-domains-inline-properties

# Conflicts:
#	static/schemas/source/adagents.json
@bokelley bokelley marked this pull request as ready for review May 22, 2026 18:17

@aao-release-bot aao-release-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Completes the two-of-three enumeration introduced in #4536; the underlying regardless of where else it appears normative was already load-bearing, this just makes it machine-scannable for SDK code-gen.

Things I checked

  • inline_properties JSON path verified by walking the discriminated union: adagents.json:401-414 (companion properties[]core/property.json:59-62 defines publisher_domain). authorized_agents[].properties[].publisher_domain is the right shape.
  • Schema description (static/schemas/source/adagents.json:95) and docs bullet (docs/governance/property/managed-networks.mdx:638) are textually consistent — same three branches, same ordering, same (inline_properties authorization type) parenthetical, same Oxford comma.
  • patch changeset is the right semver: description-string-only, no field renames, no enum changes, no required/optional flips, no new fields. No wire-shape change.
  • oneOf discriminator structures at adagents.json:224, 401, 487 are untouched — audit walker / baseline unaffected.
  • Collateral check: other revoked_publisher_domains mentions (docs/governance/property/adagents.mdx:178, 533, docs/aao/directory-api.mdx:185, static/schemas/source/aao/agent-publishers.json:89) use the catch-all regardless of where else it appears phrasing or don't enumerate branches — no drift created.
  • Good incidental fix: adding the authorized_agents[]. prefix to the publisher_properties path in the docs bullet — every branch in the enumeration now carries an explicit root anchor.

Safe to merge.

@aao-release-bot

Copy link
Copy Markdown
Contributor

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@bokelley bokelley merged commit b8b890f into main May 22, 2026
20 checks passed
@bokelley bokelley deleted the claude/issue-4869-revoked-domains-inline-properties branch May 22, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-triaged Issue has been triaged by the Claude Code triage routine. Remove to re-triage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify: does revoked_publisher_domains apply to inline_properties[]?

2 participants