[codex] Fix creative transformer follow-ups#5377
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
# Conflicts: # docs/reference/whats-new-in-3-1.mdx
Contributor
There was a problem hiding this comment.
Clean follow-up cleanup from #5219 — docs now match the schema instead of contradicting it, and the plural-target path is no longer a validation gap. The right shape: the migration guide was the last doc still claiming per-output pricing "does not survive the move," and the schema (applies_to_output_format_ids + UNPRICEABLE_OUTPUT) already disagrees.
Things I checked
- Docs match the wire, verbatim. New prose at
creative-transformers.mdx:58("unscoped option is the default for any output," reject withUNPRICEABLE_OUTPUTrather than guess) is a near-verbatim restatement of the authoritative descriptions instatic/schemas/source/core/vendor-pricing-option.json:17andstatic/schemas/source/enums/error-code.json:118.ad-tech-protocol-expert: sound. No spec drift — both fields already shipped, this PR only aligns prose. - No dangling "split into per-price-point transformers" guidance. Both rewritten passages (L58, L70) are the only occurrences; bullet #2's "See the pricing note above" cross-ref still resolves.
docs-expert: lands-well. - Plural target validation is correct.
targetIds(task-handlers.ts:6755) is the canonical merge oftarget_format_idsplural /target_format_idsingular, capped at 50. The newfindIndexmapsinvalidTargetIndexto the righttarget_format_ids[i]slot, and thereq.target_format_ids?.lengthguard picks the right field name. Behavior change is correct: a target outside the transformer'soutput_format_idsnow fails closed regardless of which field carried it. - Empty-options change is fail-closed, not a regression.
task-handlers.ts:3407dropping thefiltered.length > 0guard means a zero-match brief returnsoptions: []instead of silently widening to the full catalog. Paging handles the empty set cleanly (moreOptions = false, no cursor). Tested. The field outlives its data was the old failure mode; this kills it. - Empty changeset is correct, not missing. Per
.agents/playbook.md:289-293, empty frontmatter is the sanctioned mechanism for changes that don't touch the published protocol surface (static/schemas/source/**). This PR touches none.code-reviewerflagged it Blocker; overruling on the strength of the playbook policy plus zero schema-source files in the diff.
Follow-ups (non-blocking — file as issues)
task-handlers.ts:6794—targetIds[0] ?? req.target_format_id ?? ...: the?? req.target_format_idis dead.targetIds[0]already derives fromreq.target_format_idin every path, so the fallback can never change the result. Drop it.creative-transformers.mdx:24— the "What changed" table still describes pricing as "per transformer" without noting per-output scoping survives viaapplies_to_output_format_ids. Untouched by this PR and not contradictory, just coarse. Optional one-line append.
Minor nits (non-blocking)
- Error-message wording shift.
task-handlers.ts:6785moved fromtarget_format_id "X" is not...toTarget format "X" is not.... The new test matches oncode/fieldonly, so nothing breaks — but any downstream string-match on the old message would. Heads-up, not a fix.
Approving on the strength of the protocol-conformance verdict plus the fail-closed validation. Follow-ups noted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the creative transformer follow-ups from PR #5219 by aligning migration/release docs with
applies_to_output_format_ids, makinglist_transformersno-match brief expansion return no options, and validating pluraltarget_format_idsagainst transformer outputs.Adds focused regression coverage plus an empty changeset for the docs/training-agent-only patch.
Validation: focused transformer tests, typecheck, precommit, pre-push storyboard matrices, and docs broken-link check.