Fix Addie performance metrics SQL and data storage#617
Merged
Conversation
- Fix PostgreSQL ROUND() function calls with FILTER clause by wrapping aggregate expressions in parentheses before casting to numeric - Add performance data (latency, tokens, timing) to reaction handler - Add error handling for reaction message logging - Add logging when streaming completes without done event - Change || to ?? (nullish coalescing) to preserve 0 values for tokens The main bug was SQL queries failing with "function round(double precision, integer) does not exist" because ROUND() requires numeric type, and the ::numeric cast wasn't being applied to the full aggregate expression. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
||to??(nullish coalescing) to preserve 0 values for tokensRoot Cause
The Performance tab in the Addie admin was showing an internal server error. The SQL queries were failing with:
PostgreSQL's
ROUND(value, precision)requires the first argument to benumeric, notdouble precision. The queries were using:But the
::numericcast wasn't being applied correctly to the aggregate result - it was parsing ambiguously with the FILTER clause. The fix is to wrap the aggregate in parentheses:Test plan
🤖 Generated with Claude Code