Fix profile modal Continue button not working on dashboard#619
Merged
Conversation
The profile modal's Continue button wasn't enabling when users selected options on mobile/some browsers. The issue was that onclick handlers on <label> elements containing radio buttons don't fire reliably due to the native label-for-input behavior interfering with the event. Changes: - Add proper change event listeners to radio inputs via initProfileModalListeners() - Refactor to reduce code duplication using a radioGroups array - Remove redundant inline onclick attributes from labels - Add CSS :has() fallback for styling when radio is checked - Explicitly set radio.checked = true in selectProfileOption() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onclickhandlers on<label>elements containing radio buttons don't fire reliably due to native label-for-input behaviorchangeevent listeners to radio inputs viainitProfileModalListeners()for reliable cross-browser supportChanges
initProfileModalListeners(): Attaches change event listeners to radio buttons, which is more reliable than onclick on labelsradioGroupsarray to eliminate code duplication:has(input[type="radio"]:checked)ensures visual styling even if JS state gets out of syncselectProfileOption()now explicitly setsradio.checked = trueTest plan
🤖 Generated with Claude Code