fix: handle email-only feeds and HTML responses in feed fetcher#651
Merged
Conversation
- Add RSS content validation to detect when feeds return HTML instead of XML (e.g., when sites disable their RSS feeds and redirect to homepage) - Allow NULL feed_url for email-only feeds in database schema - Update getFeedsToFetch() to exclude email-only feeds (feed_url IS NULL) - Migrate existing email:// placeholder URLs to NULL 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1a158cb to
930455a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feed_urlfor email-only feeds in database schemagetFeedsToFetch()to exclude email-only feeds (feed_url IS NULL)email://placeholder URLs to NULLProblem
Tipsheet.ai (and potentially other sites) have disabled their RSS feeds. When the fetcher tried to parse the redirected HTML as XML, it failed with a cryptic error:
Invalid character in entity name Line: 43 Column: 1084 Char: &Additionally, the database schema had a NOT NULL constraint on
feed_url, preventing email-only feeds from being created through the UI (which sendsfeed_url: null).Solution
feed_urlwith partial unique index for non-null URLsTest plan
feed_url = NULLfor email-only feeds🤖 Generated with Claude Code