fix: resolve Slack/WorkOS leader IDs for chapter event management#688
Merged
Conversation
Chapter leaders added via Slack ID before linking their WorkOS account couldn't manage events because the leader permission checks compared stored Slack IDs against login WorkOS IDs. Changes: - getLeaders/getLeadersBatch: Resolve canonical_user_id via slack_user_mappings - isLeader: Check both direct user_id match and Slack→WorkOS mapping - getCommitteesLedByUser: Support both ID types with DISTINCT count - content.ts: Fix is_leader subqueries to use mapping join - member-context.ts: Fix pending content leader query - outbound-db.ts: Fix capability counts for leaders 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Based on code review feedback: - Remove redundant resolveToCanonicalUserId() calls in isLeader() and getCommitteesLedByUser() since the JOIN handles ID resolution - Add consistent AND sm.workos_user_id IS NOT NULL to all JOINs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack_user_mappingstable JOINChanges
getLeaders/getLeadersBatch: UseCOALESCE(sm.workos_user_id, wgl.user_id)to resolve canonical IDisLeader: Check bothwgl.user_id = $1 OR sm.workos_user_id = $1getCommitteesLedByUser: Same bidirectional checkcontent.ts: Fix is_leader subqueries in collections and pending contentmember-context.ts: Fix leader query for pending contentoutbound-db.ts: Fix capability count queriesTest plan
🤖 Generated with Claude Code